Skip to content

Add Dockerfile to examples/puzzletron#2009

Open
grzegorz-k-karch wants to merge 4 commits into
puzzletron_v2from
gkarch/puzzletron_v2-nano-dockerfile
Open

Add Dockerfile to examples/puzzletron#2009
grzegorz-k-karch wants to merge 4 commits into
puzzletron_v2from
gkarch/puzzletron_v2-nano-dockerfile

Conversation

@grzegorz-k-karch

Copy link
Copy Markdown
Contributor

What does this PR do?

Type of change: ?

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

Make sure you read and follow Contributor guidelines and your commits are signed (git commit -s -S).

Make sure you read and follow the Security Best Practices (e.g. avoiding hardcoded trust_remote_code=True, torch.load(..., weights_only=False), pickle, etc.).

  • Is this change backward compatible?: ✅ / ❌ / N/A
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: ✅ / ❌ / N/A
  • Did you write any new necessary tests?: ✅ / ❌ / N/A
  • Did you update Changelog?: ✅ / ❌ / N/A
  • Did you get Claude approval on this PR?: ✅ / ❌ / N/A

Additional Information

Signed-off-by: Grzegorz Karch <gkarch@nvidia.com>
Signed-off-by: Grzegorz Karch <gkarch@nvidia.com>
Signed-off-by: Grzegorz Karch <gkarch@nvidia.com>
@grzegorz-k-karch grzegorz-k-karch self-assigned this Jul 23, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • main
  • release/.*
  • feature/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4eba7926-3e5c-41cd-85b3-198afb109d7d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gkarch/puzzletron_v2-nano-dockerfile

Comment @coderabbitai help to get the list of available commands.

@grzegorz-k-karch grzegorz-k-karch changed the title Gkarch/puzzletron v2 nano dockerfile Add Dockerfile to examples/puzzletron Jul 23, 2026
@grzegorz-k-karch
grzegorz-k-karch marked this pull request as ready for review July 23, 2026 08:27
@grzegorz-k-karch
grzegorz-k-karch requested a review from a team as a code owner July 23, 2026 08:27
Signed-off-by: Grzegorz Karch <gkarch@nvidia.com>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need such a complicated setup? Can we just use nemo:26.06 as base container and install puzzletron dependencies on top of it? Would be much simpler and also much faster docker build step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants