helm: add nodeSelector and tolerations to NIMCache templates#1645
Open
abhay1999 wants to merge 2 commits intoNVIDIA:mainfrom
Open
helm: add nodeSelector and tolerations to NIMCache templates#1645abhay1999 wants to merge 2 commits intoNVIDIA:mainfrom
abhay1999 wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
NIMCache resources were missing nodeSelector and tolerations fields across all Operator-mode templates. Without these, NIMCache pods cannot be scheduled on GPU nodes that have taints or require specific node selection (e.g. cloud provider GPU node pools). The NIMService sections of the same templates already expose these fields correctly. This commit adds the equivalent fields to the NIMCache sections of all eight affected templates, and also adds the missing nodeSelector to the NIMService sections of nemotron-nano-12b-v2-vl and nemotron-parse which only had tolerations. Fixes NVIDIA#1636 Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
Remove extra trailing blank line to satisfy pre-commit end-of-file-fixer hook. Signed-off-by: abhay1999 <abhaychaurasiya19@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1636
NIMCache resources were missing
nodeSelectorandtolerationsfields across all NIM Operator mode Helm templates. Without these fields, NIMCache pods cannot be scheduled on GPU nodes that have taints or require node selection (e.g. cloud provider GPU node pools withnvidia.com/gpu: NoScheduletaints).The
NIMServicesections of the same templates already exposed these fields correctly — this PR makesNIMCacheconsistent withNIMService.Changes
Added
nodeSelectorandtolerationsto theNIMCachespec in all 8 affected templates:helm/templates/llama-nemotron-embed-1b-v2.yamlhelm/templates/llama-nemotron-rerank-1b-v2.yamlhelm/templates/nemotron-graphic-elements-v1.yamlhelm/templates/nemotron-ocr-v1.yamlhelm/templates/nemotron-page-elements-v3.yamlhelm/templates/nemotron-table-structure-v1.yamlhelm/templates/nemotron-nano-12b-v2-vl.yaml(also adds missingnodeSelectorto NIMService)helm/templates/nemotron-parse.yaml(also adds missingnodeSelectorto NIMService)Before / After
Before — NIMCache would ignore
nodeSelector/tolerationsfromvalues.yaml, causing pods to be unschedulable on tainted GPU nodes:After — consistent with NIMService:
Testing
Verified template structure matches the existing NIMService pattern used consistently across all templates in the chart.