Skip to content

Adding dataset_name argument to pipelines index() method#1665

Open
gabrielspmoreira wants to merge 5 commits intomainfrom
retrieval_bench_index
Open

Adding dataset_name argument to pipelines index() method#1665
gabrielspmoreira wants to merge 5 commits intomainfrom
retrieval_bench_index

Conversation

@gabrielspmoreira
Copy link
Contributor

Description

This MR adds a dataset_name argument to pipelines index() method (rather than setting pipeline.dataset_name directly. The dataset_name information is useful for example for caching the embeddings for a given dataset. That change will make retrieval pipelines compatible with this PR at the official vidore-benchmark repo.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • If adjusting docker-compose.yaml environment variables have you ensured those are mimicked in the Helm values.yaml file.

@gabrielspmoreira gabrielspmoreira self-assigned this Mar 19, 2026
@gabrielspmoreira gabrielspmoreira requested a review from a team as a code owner March 19, 2026 22:51
@gabrielspmoreira gabrielspmoreira requested a review from edknv March 19, 2026 22:51
@sosahi sosahi requested a review from a team as a code owner March 23, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants