Skip to content

refactor(onboard): add core FSM flow slice#4487

Merged
cv merged 67 commits into
mainfrom
stack/onboard-fsm-core-sequence-slice
Jun 9, 2026
Merged

refactor(onboard): add core FSM flow slice#4487
cv merged 67 commits into
mainfrom
stack/onboard-fsm-core-sequence-slice

Conversation

@cv

@cv cv commented May 29, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

Add a reusable core onboarding flow slice for provider/inference and sandbox. This slice can start at provider_selection, apply the provider/sandbox FSM results, and stop at the selected branch state.

Changes

  • Add coreOnboardFlowPhases() for provider/inference and sandbox phases.
  • Add runCoreOnboardFlowSequence() with stop states for openclaw and agent_setup.
  • Add tests for phase selection and branch-state handoff.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

  • Tests

    • Added comprehensive test coverage to validate core onboarding flow phases and verify proper sequence execution across various scenarios and progression paths.

  • Refactor

    • Refined core onboarding flow execution with enhanced phase selection and improved flow boundaries for better control over the onboarding progression.

cv added 30 commits May 27, 2026 15:18
@cv
docs(onboard): document FSM migration target
6b753bf 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): centralize machine state metadata
fb1b32d 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): derive session step mapping from FSM metadata
c3e4ad6 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): derive progress labels from FSM metadata
603832c 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
fix(onboard): emit lifecycle events for onboarding start
4fad8e7 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
fix(onboard): emit machine events for resume conflicts
f99e9cb 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): introduce explicit state result types
2b60df4 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): apply explicit state results through runtime
30341b0 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): make finalization return FSM result
d4ad2d9 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): make agent setup return FSM result
356c947 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): make policy setup return FSM result
2296519 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): make preflight and gateway return FSM results
67a9a1e 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): make sandbox return branch FSM result
46f4a49 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): return FSM results from provider inference
9cc15f5 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): add FSM runner shell
dbbb273 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): consume handler FSM results compatibly
6b27a0b 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): allow step recording without machine transitions
44009ad 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): plumb step mutation options through runtime
cd6e5f7 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): add record-only FSM runner adapter
e266e3b 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): return ordered provider FSM results
bf4da0b 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): run live sequence with record-only steps
212ff4d 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): let FSM handlers return result sequences
f69f60a 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): add sequence runner adapter
727ac69 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): support FSM runner stop states
75f82f7 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): define FSM flow context
59deee6 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): extract preflight and gateway FSM phases
25c5abf 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): extract provider and sandbox FSM phases
4d9cc9f 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): extract agent policy finalization FSM phases
8a5b54a 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): assemble FSM phase sequence
bec7ef8 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv
refactor(onboard): add initial FSM flow slice
0e168b3 
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv marked this pull request as ready for review June 9, 2026 08:48
jyaunches and others added 23 commits June 9, 2026 10:00
@jyaunches
Merge branch 'main' into stack/onboard-fsm-flow-context
5c7b7ee
@cv
Merge branch 'main' into stack/onboard-fsm-flow-context
83c1412
@cv
Merge branch 'stack/onboard-fsm-flow-context' into stack/onboard-fsm-…
6abbbb4 
…preflight-gateway-phases
@cv
Merge branch 'stack/onboard-fsm-preflight-gateway-phases' into stack/…
c07f0dd 
…onboard-fsm-provider-sandbox-phases
@cv
Merge branch 'stack/onboard-fsm-provider-sandbox-phases' into stack/o…
cf6c2a9 
…nboard-fsm-agent-policy-finalization-phases
@cv
Merge branch 'stack/onboard-fsm-agent-policy-finalization-phases' int…
4a297d0 
…o stack/onboard-fsm-flow-sequence
@cv
Merge branch 'stack/onboard-fsm-flow-sequence' into stack/onboard-fsm…
cfdaf52 
…-initial-sequence-slice
@cv
Merge branch 'stack/onboard-fsm-initial-sequence-slice' into stack/on…
848ed51 
…board-fsm-core-sequence-slice
@cv
Merge branch 'main' into stack/onboard-fsm-flow-context
23e8577
@cv
chore: apply static formatting for FSM flow stack
abbd8c4
@cv
Merge remote-tracking branch 'origin/stack/onboard-fsm-flow-context' …
b592eac 
…into stack/onboard-fsm-preflight-gateway-phases
@cv
chore(onboard): format preflight gateway FSM phase
adbbdfa
@cv
Merge remote-tracking branch 'origin/stack/onboard-fsm-preflight-gate…
8a6bca2 
…way-phases' into stack/onboard-fsm-provider-sandbox-phases
@cv
chore(onboard): format provider sandbox FSM phase
baeab37
@cv
Merge remote-tracking branch 'origin/stack/onboard-fsm-provider-sandb…
5118bd7 
…ox-phases' into stack/onboard-fsm-agent-policy-finalization-phases
@cv
chore(onboard): format finalization FSM phases
a64242b
@cv
Merge remote-tracking branch 'origin/stack/onboard-fsm-agent-policy-f…
32059c9 
…inalization-phases' into stack/onboard-fsm-flow-sequence
@cv
chore(onboard): format FSM flow sequence
3562942
@cv
Merge remote-tracking branch 'origin/stack/onboard-fsm-flow-sequence'…
c2bb6a9 
… into stack/onboard-fsm-initial-sequence-slice
@cv
Merge remote-tracking branch 'origin/stack/onboard-fsm-initial-sequen…
ac0a73c 
…ce-slice' into stack/onboard-fsm-core-sequence-slice
@cv
chore(onboard): format core FSM flow slice
b193221
@cv
Merge branch 'main' into stack/onboard-fsm-initial-sequence-slice
69d537d
@cv
Merge branch 'stack/onboard-fsm-initial-sequence-slice' into stack/on…
90fedc3 
…board-fsm-core-sequence-slice
Base automatically changed from stack/onboard-fsm-initial-sequence-slice to main June 9, 2026 19:41
@cv
Merge remote-tracking branch 'origin/main' into stack/onboard-fsm-cor…
b6e3eb6 
…e-sequence-slice

# Conflicts:
#	src/lib/onboard/machine/flow-slices.test.ts
#	src/lib/onboard/machine/flow-slices.ts
@copy-pr-bot

copy-pr-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cv cv merged commit 30719af into main Jun 9, 2026
94 of 95 checks passed
@cv cv deleted the stack/onboard-fsm-core-sequence-slice branch June 9, 2026 20:04
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Selective E2E Results — ✅ All requested jobs passed

Run: 27232378703
Target ref: b6e3eb6c3541a408df985618493344c8e498e812
Workflow ref: main
Requested jobs: cloud-onboard-e2e
Summary: 1 passed, 0 failed, 0 skipped

Job Result
cloud-onboard-e2e ✅ success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cv cv

Labels

area: onboarding Onboarding FSM, provider setup, sandbox launch, or first-run flow refactor PR restructures code without intended behavior change v0.0.62 Release target

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cv @wscurran @jyaunches