test(onboard): cover live FSM slice boundaries by cv · Pull Request #4531 · NVIDIA/NemoClaw

cv · 2026-05-29T15:50:47Z

Summary

Add subprocess coverage that proves fresh onboarding enters each live FSM slice boundary. The tests patch the slice helpers before loading onboard, then verify initial, core, and final slices are reached in order.

Changes

Add test/onboard-fsm-live-slices.test.ts.
Cover initial slice entry on fresh onboarding.
Cover core slice entry after the initial slice reaches provider selection.
Cover final slice entry after the core slice reaches the branch state.

Type of Change

Code change (feature, bug fix, or refactor)
Code change with doc updates
Doc only (prose changes, no code sample modifications)
Doc only (includes code sample changes)

Verification

npx prek run --all-files passes
npm test passes
Tests added or updated for new or changed behavior
No secrets, API keys, or credentials committed
Docs updated for user-facing behavior changes
npm run docs builds without warnings (doc changes only)
Doc pages follow the style guide (doc changes only)
New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

Tests
- Added comprehensive end-to-end test suite validating onboard FSM slice boundary behavior by running compiled artifacts in isolated Node processes, checking build outputs, and verifying handlers are invoked in the correct order for fresh and resumed scenarios.

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

…ice' into stack/onboard-fsm-use-core-slice # Conflicts: # src/lib/onboard.ts

…' into stack/onboard-fsm-use-final-slice # Conflicts: # src/lib/onboard.ts

…e' into stack/onboard-fsm-live-slice-helper

…per' into stack/onboard-fsm-live-slice-boundary-tests

copy-pr-bot · 2026-06-09T20:35:48Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

…al-sequence-slice # Conflicts: # src/lib/onboard/machine/flow-slices.test.ts # src/lib/onboard/machine/flow-slices.ts

…-slice' into stack/onboard-fsm-use-initial-slice

…ice' into stack/onboard-fsm-use-core-slice

…' into stack/onboard-fsm-use-final-slice

…e' into stack/onboard-fsm-live-slice-helper

…per' into stack/onboard-fsm-live-slice-boundary-tests

…ice' into stack/onboard-fsm-use-core-slice

…' into stack/onboard-fsm-use-final-slice

…e' into stack/onboard-fsm-live-slice-helper

…per' into stack/onboard-fsm-live-slice-boundary-tests

# Conflicts: # src/lib/onboard.ts # src/lib/onboard/machine/core-flow-phases.test.ts # src/lib/onboard/machine/core-flow-phases.ts # src/lib/onboard/machine/final-flow-phases.test.ts # src/lib/onboard/machine/final-flow-phases.ts # src/lib/onboard/machine/initial-flow-phases.test.ts # src/lib/onboard/machine/initial-flow-phases.ts # src/lib/onboard/machine/live-flow-slice.test.ts # src/lib/onboard/machine/live-flow-slice.ts

cv added 30 commits May 27, 2026 15:18

docs(onboard): document FSM migration target

6b753bf

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): centralize machine state metadata

fb1b32d

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): derive session step mapping from FSM metadata

c3e4ad6

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): derive progress labels from FSM metadata

603832c

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

fix(onboard): emit lifecycle events for onboarding start

4fad8e7

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

fix(onboard): emit machine events for resume conflicts

f99e9cb

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): introduce explicit state result types

2b60df4

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): apply explicit state results through runtime

30341b0

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): make finalization return FSM result

d4ad2d9

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): make agent setup return FSM result

356c947

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): make policy setup return FSM result

2296519

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): make preflight and gateway return FSM results

67a9a1e

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): make sandbox return branch FSM result

46f4a49

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): return FSM results from provider inference

9cc15f5

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): add FSM runner shell

dbbb273

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): consume handler FSM results compatibly

6b27a0b

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): allow step recording without machine transitions

44009ad

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): plumb step mutation options through runtime

cd6e5f7

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): add record-only FSM runner adapter

e266e3b

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): return ordered provider FSM results

bf4da0b

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): run live sequence with record-only steps

212ff4d

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): let FSM handlers return result sequences

f69f60a

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): add sequence runner adapter

727ac69

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): support FSM runner stop states

75f82f7

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): define FSM flow context

59deee6

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): extract preflight and gateway FSM phases

25c5abf

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): extract provider and sandbox FSM phases

4d9cc9f

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): extract agent policy finalization FSM phases

8a5b54a

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): assemble FSM phase sequence

bec7ef8

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

refactor(onboard): add initial FSM flow slice

0e168b3

Signed-off-by: Carlos Villela <cvillela@nvidia.com>

cv added 7 commits June 9, 2026 13:10

refactor(onboard): extract initial FSM flow phases

fba2f8c

Merge remote-tracking branch 'origin/stack/onboard-fsm-use-initial-sl…

a6406c0

…ice' into stack/onboard-fsm-use-core-slice # Conflicts: # src/lib/onboard.ts

Merge remote-tracking branch 'origin/stack/onboard-fsm-use-core-slice…

d948c12

…' into stack/onboard-fsm-use-final-slice # Conflicts: # src/lib/onboard.ts

Merge remote-tracking branch 'origin/stack/onboard-fsm-use-final-slic…

55d6244

…e' into stack/onboard-fsm-live-slice-helper

chore(onboard): format live flow slice helper

dc8119c

Merge remote-tracking branch 'origin/stack/onboard-fsm-live-slice-hel…

66b2ba3

…per' into stack/onboard-fsm-live-slice-boundary-tests

chore(onboard): format live slice boundary test

211b379

cv added 12 commits June 9, 2026 13:39

Merge remote-tracking branch 'origin/main' into stack/onboard-fsm-fin…

7be0d7b

…al-sequence-slice # Conflicts: # src/lib/onboard/machine/flow-slices.test.ts # src/lib/onboard/machine/flow-slices.ts

Merge remote-tracking branch 'origin/stack/onboard-fsm-final-sequence…

455c664

…-slice' into stack/onboard-fsm-use-initial-slice

Merge remote-tracking branch 'origin/stack/onboard-fsm-use-initial-sl…

89de2fa

…ice' into stack/onboard-fsm-use-core-slice

Merge remote-tracking branch 'origin/stack/onboard-fsm-use-core-slice…

a4a6773

…' into stack/onboard-fsm-use-final-slice

Merge remote-tracking branch 'origin/stack/onboard-fsm-use-final-slic…

c0dd16a

…e' into stack/onboard-fsm-live-slice-helper

Merge remote-tracking branch 'origin/stack/onboard-fsm-live-slice-hel…

e36d763

…per' into stack/onboard-fsm-live-slice-boundary-tests

fix(onboard): enter initial FSM slice from init state

02dcc8c

Merge remote-tracking branch 'origin/stack/onboard-fsm-use-initial-sl…

725fb30

…ice' into stack/onboard-fsm-use-core-slice

Merge remote-tracking branch 'origin/stack/onboard-fsm-use-core-slice…

0b54044

…' into stack/onboard-fsm-use-final-slice

Merge remote-tracking branch 'origin/stack/onboard-fsm-use-final-slic…

f4910a8

…e' into stack/onboard-fsm-live-slice-helper

Merge remote-tracking branch 'origin/stack/onboard-fsm-live-slice-hel…

354a3da

…per' into stack/onboard-fsm-live-slice-boundary-tests

test(onboard): mirror initial FSM transitions in live probe

ed8b7e4

cv added v0.0.63 Release target and removed v0.0.62 Release target labels Jun 10, 2026

Base automatically changed from stack/onboard-fsm-live-slice-helper to main June 10, 2026 03:12

cv marked this pull request as ready for review June 10, 2026 04:49

test(onboard): enforce live slice dist coverage

15bd587

cv merged commit 1c77b74 into main Jun 10, 2026
30 checks passed

cv deleted the stack/onboard-fsm-live-slice-boundary-tests branch June 10, 2026 05:46

cv mentioned this pull request Jun 10, 2026

Umbrella: refactor onboarding into a serializable FSM #3802

Closed

coderabbitai Bot mentioned this pull request Jun 10, 2026

test(e2e): add Vitest live coverage for onboard resume #5147

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(onboard): cover live FSM slice boundaries#4531

test(onboard): cover live FSM slice boundaries#4531
cv merged 103 commits into
mainfrom
stack/onboard-fsm-live-slice-boundary-tests

cv commented May 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

copy-pr-bot Bot commented Jun 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cv commented May 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Type of Change

Verification

Summary by CodeRabbit

Uh oh!

copy-pr-bot Bot commented Jun 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cv commented May 29, 2026 •

edited by coderabbitai Bot

Loading