test(e2e): freeze legacy YAML/bash scenario runner#5073
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-advisor-raw-output.txt |
E2E Scenario Advisor RecommendationRequired scenario E2E: None Full scenario advisor summaryE2E Scenario AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-scenario-advisor-raw-output.txt |
PR Review AdvisorFindings: 0 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
This is an automated advisory review. A human maintainer must make the final merge decision. |
Status after #5106This draft is superseded by #5106, which has now merged the typed-shell-runner cutover and removed the legacy YAML/bash scenario runner path from The remaining clarification from the current discussion is terminology: we should avoid describing the end state as “some E2Es stay bash, some E2Es are Vitest.” The end state is one Vitest-driven E2E system. Shell remains only as a subprocess/system-boundary mechanism inside Vitest tests or fixtures when the behavior being tested is shell/user-environment behavior. Follow-up work should probably move under #5098/#4999 rather than continue this draft as a separate freeze step. |
Summary
Draft planning PR for the E2E Vitest fan-out stack. This PR scopes guardrails that stop new durable coverage from landing in the legacy runner.
Related Issue
Refs #4941
Refs #4990
Refs #4357
Depends on #5046, #5052, and the shared runtime-suite base stack.
Stacked on branch
codex/e2e-fanout-21-nightly-regression-vitest.Changes
test(e2e): freeze legacy YAML/bash scenario runner.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com