Skip to content

test(e2e): freeze legacy YAML/bash scenario runner#5073

Closed
cv wants to merge 1 commit into
codex/e2e-fanout-21-nightly-regression-vitestfrom
codex/e2e-fanout-22-freeze-legacy-yaml-bash-runner
Closed

test(e2e): freeze legacy YAML/bash scenario runner#5073
cv wants to merge 1 commit into
codex/e2e-fanout-21-nightly-regression-vitestfrom
codex/e2e-fanout-22-freeze-legacy-yaml-bash-runner

Conversation

@cv

@cv cv commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Draft planning PR for the E2E Vitest fan-out stack. This PR scopes guardrails that stop new durable coverage from landing in the legacy runner.

Related Issue

Refs #4941
Refs #4990
Refs #4357
Depends on #5046, #5052, and the shared runtime-suite base stack.
Stacked on branch codex/e2e-fanout-21-nightly-regression-vitest.

Changes

  • Placeholder branch for test(e2e): freeze legacy YAML/bash scenario runner.
  • Planned scope: Mark legacy YAML/bash runner surfaces as frozen and add tests or lint checks preventing new durable scenario coverage outside the Vitest fixture path.
  • No implementation changes yet; this draft should remain draft until code and verification are added.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv self-assigned this Jun 9, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cv cv added area: e2e End-to-end tests, nightly failures, or validation infrastructure area: architecture Architecture, design debt, major refactors, or maintainability chore Build, CI, dependency, or tooling maintenance labels Jun 9, 2026
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 98ec0e71-3441-4bfb-866f-fb89c26fea3b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/e2e-fanout-22-freeze-legacy-yaml-bash-runner

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Failed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-advisor-raw-output.txt

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

E2E Scenario Advisor Recommendation

Required scenario E2E: None
Optional scenario E2E: None

Workflow run

Full scenario advisor summary

E2E Scenario Advisor

Failed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-scenario-advisor-raw-output.txt

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 1 worth checking, 0 nice ideas
Top item: PR review advisor unavailable

Review findings

🛠️ Needs attention

  • None.

🔎 Worth checking

  • PR review advisor unavailable: The automated advisor could not complete: Could not parse JSON from PR review advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/pr-review-advisor/pr-review-advisor-raw-output.txt
    • Recommendation: Re-run the PR Review Advisor or perform a manual review.
    • Evidence: Could not parse JSON from PR review advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/pr-review-advisor/pr-review-advisor-raw-output.txt

🌱 Nice ideas

  • None.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@cv

cv commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Status after #5106

This draft is superseded by #5106, which has now merged the typed-shell-runner cutover and removed the legacy YAML/bash scenario runner path from main.

The remaining clarification from the current discussion is terminology: we should avoid describing the end state as “some E2Es stay bash, some E2Es are Vitest.” The end state is one Vitest-driven E2E system. Shell remains only as a subprocess/system-boundary mechanism inside Vitest tests or fixtures when the behavior being tested is shell/user-environment behavior.

Follow-up work should probably move under #5098/#4999 rather than continue this draft as a separate freeze step.

@cv

cv commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #5106, which has now landed the typed-shell-runner cutover and removed the legacy YAML/bash scenario runner path from main. Remaining legacy test/e2e/test-*.sh migration continues under #5098/#4999.

@cv cv closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: architecture Architecture, design debt, major refactors, or maintainability area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants