Skip to content

docs(skills): refresh managed-vLLM catalog skills#5162

Merged
cv merged 5 commits into
mainfrom
codex/refresh-managed-vllm-skills
Jun 12, 2026
Merged

docs(skills): refresh managed-vLLM catalog skills#5162
cv merged 5 commits into
mainfrom
codex/refresh-managed-vllm-skills

Conversation

@cv

@cv cv commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Refreshes the published catalog copies of the generated inference and reference user skills so they match the source .agents/skills output after #5038. This addresses the review advisor finding that the root skills/ packages still had stale managed-vLLM defaults and override slugs.

Related Issue

Follow-up to #5038; addresses #5038 (comment).

Changes

  • Refreshed skills/nemoclaw-user-configure-inference from the generated .agents source while preserving catalog-only metadata and signing artifacts.
  • Refreshed skills/nemoclaw-user-reference from the generated .agents source while preserving catalog-only metadata and signing artifacts.
  • Updated the published skill references to list DGX Spark as qwen3.6-35b-a3b-nvfp4 / nvidia/Qwen3.6-35B-A3B-NVFP4, DGX Station as qwen3.6-27b / Qwen/Qwen3.6-27B-FP8, generic Linux as nemotron-3-nano-4b / nvidia/NVIDIA-Nemotron-3-Nano-4B-FP8, and the deepseek-v4-flash override slug.
  • Removed the stale published use-local-inference-details.md reference file because the current generated inference skill carries that content in references/inference-options.md.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

npm run docs completed with 0 errors, but Fern reported two pre-existing/environmental warnings: unauthenticated redirects check skipped, and a light-mode accent contrast warning.


Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

  • Documentation
    • Major overhaul of local inference onboarding and references: Ollama, vLLM, GPU fallbacks, context-window behavior, WSL/Windows-host nuances, install-mode guidance, PATH/zstd hints, and Docker/WSL restriction + remediation.
    • Consolidated and clarified model-switching, validation/retry/timeout rules, proxy health/token semantics, CLI examples, network policy presets, and troubleshooting.
    • Removed/merged older local-inference detail pages into centralized guidance.
  • Tests
    • Added an eval constraint to discourage fabrication when the skill cannot answer.

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv added area: docs Documentation, examples, guides, or docs build area: skills Skills, agent behaviors, prompts, or skill packaging labels Jun 10, 2026
@cv cv self-assigned this Jun 10, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0c4b45e9-dce0-48cc-8cf5-5b88ff00cd09

📥 Commits

Reviewing files that changed from the base of the PR and between 92ffbc3 and c5a82da.

📒 Files selected for processing (1)
  • skills/nemoclaw-user-reference/references/architecture.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skills/nemoclaw-user-reference/references/architecture.md

📝 Walkthrough

Walkthrough

Consolidates and expands NemoClaw documentation for inference configuration, provider onboarding, runtime model switching, CLI commands, architecture, and troubleshooting with OpenClaw/Hermes-specific guidance.

Changes

Inference Configuration Consolidation and Provider Guidance

Layer / File(s) Summary
User Configure Inference Skill Guide Restructuring
skills/nemoclaw-user-configure-inference/SKILL.md, .agents/skills/.../SKILL.md
Refactors skill front-matter and prerequisites, adds AgentOnly, rewrites Ollama onboarding (WSL/Windows-host constraints), expands Linux install guidance, updates proxy walkthrough, and consolidates per-server setup into centralized references.
Inference Options Centralized Setup and Validation
skills/nemoclaw-user-configure-inference/references/inference-options.md
Adds OpenClaw vs Hermes onboarding blocks, refines provider options and curated models, expands Model Router YAML example and host-Python pinning, and details validation/retry rules plus OpenAI/Anthropic/vLLM/NIM setup and timeout tuning.
Runtime Model Switching and Tool-Calling Reliability
skills/nemoclaw-user-configure-inference/references/switch-inference-providers.md, skills/nemoclaw-user-configure-inference/references/tool-calling-reliability.md
Documents nemoclaw inference set runtime behavior for OpenClaw/Hermes, API-family sync, streaming detection, NEMOCLAW_PREFERRED_API usage, metadata tuning and verification, and recommends vLLM + tool-call parser for complex OpenClaw loops.
Sub-Agent Configuration Formatting
skills/nemoclaw-user-configure-inference/references/set-up-sub-agent.md
Reformats command/examples and credential ownership snippets for OpenClaw Omni sub-agent setup.
Inference Options Evaluation Constraint
skills/nemoclaw-user-configure-inference/evals/evals.json
Adds expected_behavior to docs-inference-inference-options-001 requiring use of expected_skill and forbidding fabricated answers.

CLI Commands and Environment Variable Reference Expansion

Layer / File(s) Summary
Onboarding Policy Tiers and Hermes Presets
skills/nemoclaw-user-reference/references/commands.md
Documents NEMOCLAW_POLICY_TIER non-interactive validation/defaulting, Hermes-managed tool gateway presets, and .dockerignore staging/secret exclusions for --from.
Diagnostic and Status Commands
skills/nemoclaw-user-reference/references/commands.md
Updates status examples with pinned agent versions, adds doctor --fix permission-repair docs, clarifies OpenClaw/Hermes dashboard-url semantics, and adds policy-explain.
Skill Installation and Sharing Commands
skills/nemoclaw-user-reference/references/commands.md
Adds conditional mirroring for skill install, updates share mount/share status output examples, and documents tunnel status.
Inference Routing and System Uninstall Commands
skills/nemoclaw-user-reference/references/commands.md
Documents Hermes inference set in-sandbox patch behavior (no rebuild) and expands Linux uninstall removal scope.
Environment Variable Reference and Configuration Expansion
skills/nemoclaw-user-reference/references/commands.md
Adds sandbox-name overrides, Hermes dashboard/tool-gateway envs, NEMOCLAW_EXTRA_PLACEHOLDER_KEYS rules, vLLM model selection, and advanced Linux OpenShell overrides.
User Reference Skill Entry Point
skills/nemoclaw-user-reference/SKILL.md
Rewords CLI-selection guide reference in the skill entry.

Deployment Architecture, Runtime Context, and Network Policies

Layer / File(s) Summary
Deployment Topology and Context Injection
skills/nemoclaw-user-reference/references/architecture.md
Clarifies Linux package-managed gateway ownership checks and standalone fallback, Apple Silicon behavior, OPENSHELL_DRIVERS handling, and OpenClaw runtime-context injection semantics.
Network Policy Tier Presets and Non-Interactive Validation
skills/nemoclaw-user-reference/references/network-policies.md
Updates Balanced/Open tier preset lists and documents non-interactive NEMOCLAW_POLICY_TIER validation with early-exit on invalid non-blank values.

Enhanced Troubleshooting and Platform-Specific Guidance

Layer / File(s) Summary
Managed Inference and Container Platform Troubleshooting
skills/nemoclaw-user-reference/references/troubleshooting.md
Adds Docker 29+/containerd image-store notes for managed NIM digests, Ollama cold model-load retry behavior, and other platform diagnostics.
Config Permissions and Gateway Write Access
skills/nemoclaw-user-reference/references/troubleshooting.md
Documents openclaw doctor --fix behavior, no-rebuild repair steps, permission-drift interpretation, and in-container verification guidance.
Proxy and Host Connectivity Troubleshooting
skills/nemoclaw-user-reference/references/troubleshooting.md
Expands NO_PROXY recommendations, clarifies internal L7 routing for inference.local, and reformats host reachability/health-check examples.
GPU Recovery and Ollama Context-Length Handling
skills/nemoclaw-user-reference/references/troubleshooting.md
Adds GPU patch rollback/recovery guidance and notes that Ollama context lengths below 16384 are raised to 16384 when NEMOCLAW_CONTEXT_WINDOW is unset.
Hermes Onboarding and Authentication Troubleshooting
skills/nemoclaw-user-reference/references/troubleshooting.md
Adds Hermes conversion, auth-method selection, Bearer token diagnostics, and re-onboarding examples for messaging bot tokens.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • NVIDIA/NemoClaw#4744: Overlapping eval update requiring use of expected_skill and forbidding fabrication.
  • NVIDIA/NemoClaw#5244: Related vLLM onboarding/model-selection docs that intersect with inference-options changes.
  • NVIDIA/NemoClaw#1460: Prior docs reorganization touching inference options and model-switching guidance.

Suggested labels

documentation

Suggested reviewers

  • jyaunches
  • prekshivyas
  • ericksoa

"I'm a rabbit with a pen and a grin,
Docs pruned and sorted, tidy within.
Ollama, vLLM, Hermes lined in a row,
Users guided clearly so setups can flow.
Hopping off — may this merge land and grow!"

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main changeset: refreshing published skill documentation to align with generated managed-vLLM catalog outputs from PR #5038.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/refresh-managed-vllm-skills

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: cloud-inference-e2e, skill-agent-e2e

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • None. No merge-blocking E2E is required because the diff is limited to Markdown skill/reference assets and skill eval JSON. It does not change installer/onboarding code, sandbox lifecycle code, credential handling, network-policy assets, inference routing implementation, deployment code, or runtime assistant binaries. Existing PR docs/link and skill validation checks are more appropriate than full live E2E for this change; optional E2E can be run for extra confidence only.

Optional E2E

  • cloud-inference-e2e (high; live sandbox install plus NVIDIA endpoint inference): Optional confidence only: this nightly E2E includes a live cloud-inference assistant flow and validates repository .agents/skills SKILL.md frontmatter/body. It may catch gross breakage in the changed .agents skill, but it does not evaluate the changed skill answers or most files under skills/.
  • skill-agent-e2e (high; live sandbox install plus LLM turn): Optional adjacent coverage: verifies an OpenClaw agent can read a managed SKILL.md inside a real sandbox. Useful if maintainers want live confidence in the skill-loading user flow, but it uses a fixture skill rather than the changed NemoClaw user skills.

New E2E recommendations

  • changed-skill-answer-quality (high): Existing E2E jobs do not run the modified skills/nemoclaw-user-configure-inference/evals/evals.json questions against the changed skill bundle or assert that answers cite the reorganized references correctly.
    • Suggested test: Add a skill-eval CI job that runs changed skill evals for nemoclaw-user-configure-inference and nemoclaw-user-reference, including expected_skill selection and no-hallucination checks after reference-file moves/deletions.
  • skill-markdown-link-and-import-validation (medium): The PR deletes use-local-inference-details.md and introduces AgentOnly imports in skill Markdown. Existing docs-validation-e2e does not scan skills/ and only scans .agents/skills when check-docs is invoked with --with-skills.
    • Suggested test: Add a changed-skills validation job that checks local links, deleted-reference backlinks, frontmatter, and supported MDX/AgentOnly imports across both skills/** and .agents/skills/**.
  • repository-skill-runtime-smoke (medium): Current skill-agent-e2e injects a fixture skill rather than installing or querying the repository NemoClaw user skills changed in this PR.
    • Suggested test: Add a live or hermetic repository-skill smoke that loads the changed NemoClaw skill bundle into a sandbox and asks representative prompts for inference configuration and reference lookup, asserting the expected skill is selected and no deleted reference is requested.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: None
Optional Vitest E2E scenarios: None

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required Vitest E2E scenarios

  • None. Changes are limited to skill documentation and skill eval metadata outside test/e2e-scenario/ and .github/workflows/e2e-vitest-scenarios.yaml, so they do not affect the Vitest E2E scenario registry, runtime support, fixtures, live tests, or workflow dispatch behavior.

Optional Vitest E2E scenarios

  • None.

Relevant changed files

  • None.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 6 worth checking, 0 nice ideas
Since last review: 3 prior items resolved, 5 still apply, 0 new items found

Review findings

🛠️ Needs attention

  • None.

🔎 Worth checking

  • Source-of-truth review needed: skills/nemoclaw-user-configure-inference/SKILL.md managed vLLM recovery: The advisor marked localized patch analysis as missing.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: `SKILL.md` says: `If the host reboots and the nemoclaw-vllm container is stopped, NemoClaw restarts the managed vLLM container during recovery instead of requiring a fresh onboarding run.`
  • Source-of-truth review needed: skills/nemoclaw-user-configure-inference/SKILL.md sandbox local runtime route validation: The advisor marked localized patch analysis as needs_followup.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: `SKILL.md` says NemoClaw verifies `https://inference.local/v1/models\` from inside the sandbox runtime, treats only 2xx as success, and reports endpoint/recovery steps before the first prompt if the route fails.
  • Source-of-truth review needed: skills/nemoclaw-user-configure-inference/SKILL.md Ollama auth proxy repair: The advisor marked localized patch analysis as needs_followup.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: `SKILL.md` says: `If Inference is healthy but Inference (auth proxy) is not, rerun onboarding to repair the proxy path that sandbox requests use.`
  • Windows-host Ollama guidance still binds an unauthenticated listener without a firewall caveat (skills/nemoclaw-user-configure-inference/SKILL.md:106): The WSL/Windows-host Ollama setup still tells users that install and restart paths set `OLLAMA_HOST=0.0.0.0:11434`, while the authenticated reverse proxy section states WSL Ollama paths do not use that proxy. Ollama is unauthenticated by default, so this can expose the local model API beyond the intended Docker Desktop/WSL route if Windows Firewall or equivalent host controls do not restrict LAN access.
    • Recommendation: Add a warning next to the Windows-host Ollama setup steps that this path intentionally binds Ollama for Docker Desktop/WSL reachability, does not use NemoClaw's authenticated proxy, and must be restricted to trusted Docker Desktop/WSL interfaces with Windows Firewall or equivalent host rules.
    • Evidence: `SKILL.md` says install and restart set `OLLAMA_HOST=0.0.0.0:11434`; later it says `WSL Ollama paths do not use this proxy. Windows-host Ollama uses the Windows daemon through host.docker.internal.` The troubleshooting section also suggests restarting Windows Ollama with `OLLAMA_HOST=0.0.0.0:11434` without a firewall caveat.
  • Security-sensitive inference eval coverage was collapsed to one broad prompt (skills/nemoclaw-user-configure-inference/evals/evals.json:1): The configure-inference eval suite now has one broad prompt with a generic expected behavior. The removed prompts were the focused checks most likely to catch regressions in provider credential handling, sandbox credential isolation, `inference.local` routing, sub-agent secret placement, runtime switching, rollback, and raw tool-call diagnostics.
    • Recommendation: Restore or replace focused evals for provider credential requirements, credentials staying outside the sandbox, `inference.local` gateway routing, Windows-host Ollama exposure guidance, sub-agent credential placement, runtime switching verification and rollback, and local tool-call leakage diagnostics.
    • Evidence: `evals/evals.json` now contains only `docs-inference-inference-options-001` with expected behavior `Uses the expected_skill and does not make up answers if it cannot find the answer from the skill.` The diff removes the targeted credential, routing, sub-agent, switch/rollback, and tool-calling eval entries.
  • Recovery and local-route claims still need behavior-specific source anchors (skills/nemoclaw-user-configure-inference/SKILL.md:219): The docs describe recovery and tolerant behavior in security-sensitive inference paths: restarting a stopped managed `nemoclaw-vllm` container after host reboot, reporting a failed sandbox `https://inference.local/v1/models\` runtime route before the first prompt, and rerunning onboarding to repair an unhealthy Ollama auth proxy. The PR does not identify the invalid-state source, source-fix constraint, behavior-specific regression coverage, or removal condition for each of these localized recovery paths.
    • Recommendation: Add or identify regression coverage and source-of-truth notes for each documented recovery path. At minimum, cover stopped managed-vLLM container restart after reboot, post-create Linux Docker-driver GPU `https://inference.local/v1/models\` validation before the first prompt, and rerun-onboarding repair when `Inference` is healthy but `Inference (auth proxy)` is unhealthy.
    • Evidence: `SKILL.md` states that NemoClaw restarts a stopped `nemoclaw-vllm` container during recovery, verifies `https://inference.local/v1/models\` from inside the sandbox runtime and reports recovery steps when it fails, and tells users to rerun onboarding when `Inference` is healthy but `Inference (auth proxy)` is not. Existing tests found partial proxy and inference.local probe coverage, but not behavior-specific anchors for all three documented recovery claims.

🌱 Nice ideas

  • None.
Consider writing more tests for
  • **Runtime validation** — Restore or add an eval where the answer must explain that provider credentials stay on the host and sandbox inference uses `inference.local` placeholders rather than raw API keys.. This docs/skill-packaging PR changes security-sensitive inference, credential-routing, local proxy, managed vLLM/NIM, runtime switching, recovery, and gateway ownership guidance while reducing behavior-specific skill eval coverage. Runtime and renderer validation remain important because generated/catalog drift and inaccurate recovery guidance affect what assistants instruct users to do.
  • **Runtime validation** — Restore or add an eval where Windows-host Ollama guidance must warn that `OLLAMA_HOST=0.0.0.0:11434` is unauthenticated, bypasses NemoClaw's non-WSL auth proxy, and needs Windows Firewall or equivalent restriction.. This docs/skill-packaging PR changes security-sensitive inference, credential-routing, local proxy, managed vLLM/NIM, runtime switching, recovery, and gateway ownership guidance while reducing behavior-specific skill eval coverage. Runtime and renderer validation remain important because generated/catalog drift and inaccurate recovery guidance affect what assistants instruct users to do.
  • **Runtime validation** — Restore or add an eval where sub-agent credential guidance must place auxiliary provider secrets in the per-agent auth profile, not in workspace instructions or the primary agent config.. This docs/skill-packaging PR changes security-sensitive inference, credential-routing, local proxy, managed vLLM/NIM, runtime switching, recovery, and gateway ownership guidance while reducing behavior-specific skill eval coverage. Runtime and renderer validation remain important because generated/catalog drift and inaccurate recovery guidance affect what assistants instruct users to do.
  • **Runtime validation** — Restore or add an eval where runtime model switching must verify the active route with `nemoclaw inference get` or status output and explain the rollback path.. This docs/skill-packaging PR changes security-sensitive inference, credential-routing, local proxy, managed vLLM/NIM, runtime switching, recovery, and gateway ownership guidance while reducing behavior-specific skill eval coverage. Runtime and renderer validation remain important because generated/catalog drift and inaccurate recovery guidance affect what assistants instruct users to do.
  • **Runtime validation** — Restore or add an eval where raw JSON tool-call leakage must be diagnosed as a model/server/parser compatibility issue and recommend parser-aware vLLM validation.. This docs/skill-packaging PR changes security-sensitive inference, credential-routing, local proxy, managed vLLM/NIM, runtime switching, recovery, and gateway ownership guidance while reducing behavior-specific skill eval coverage. Runtime and renderer validation remain important because generated/catalog drift and inaccurate recovery guidance affect what assistants instruct users to do.
  • **Security-sensitive inference eval coverage was collapsed to one broad prompt** — Restore or replace focused evals for provider credential requirements, credentials staying outside the sandbox, `inference.local` gateway routing, Windows-host Ollama exposure guidance, sub-agent credential placement, runtime switching verification and rollback, and local tool-call leakage diagnostics.
  • **skills/nemoclaw-user-configure-inference/SKILL.md managed vLLM recovery** — No behavior-specific test was identified for restarting a stopped managed `nemoclaw-vllm` container after reboot without requiring a fresh onboarding run.. `SKILL.md` says: `If the host reboots and the nemoclaw-vllm container is stopped, NemoClaw restarts the managed vLLM container during recovery instead of requiring a fresh onboarding run.`
  • **skills/nemoclaw-user-configure-inference/SKILL.md sandbox local runtime route validation** — Existing probe tests cover `https://inference.local/v1/models\` in status/recovery paths, including 401-as-reachable behavior, but this PR does not identify a post-create onboarding validation test that rejects non-2xx runtime route failures before the first agent prompt.. `SKILL.md` says NemoClaw verifies `https://inference.local/v1/models\` from inside the sandbox runtime, treats only 2xx as success, and reports endpoint/recovery steps before the first prompt if the route fails.
Since last review details

Current findings:

  • Source-of-truth review needed: skills/nemoclaw-user-configure-inference/SKILL.md managed vLLM recovery: The advisor marked localized patch analysis as missing.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: `SKILL.md` says: `If the host reboots and the nemoclaw-vllm container is stopped, NemoClaw restarts the managed vLLM container during recovery instead of requiring a fresh onboarding run.`
  • Source-of-truth review needed: skills/nemoclaw-user-configure-inference/SKILL.md sandbox local runtime route validation: The advisor marked localized patch analysis as needs_followup.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: `SKILL.md` says NemoClaw verifies `https://inference.local/v1/models\` from inside the sandbox runtime, treats only 2xx as success, and reports endpoint/recovery steps before the first prompt if the route fails.
  • Source-of-truth review needed: skills/nemoclaw-user-configure-inference/SKILL.md Ollama auth proxy repair: The advisor marked localized patch analysis as needs_followup.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: `SKILL.md` says: `If Inference is healthy but Inference (auth proxy) is not, rerun onboarding to repair the proxy path that sandbox requests use.`
  • Windows-host Ollama guidance still binds an unauthenticated listener without a firewall caveat (skills/nemoclaw-user-configure-inference/SKILL.md:106): The WSL/Windows-host Ollama setup still tells users that install and restart paths set `OLLAMA_HOST=0.0.0.0:11434`, while the authenticated reverse proxy section states WSL Ollama paths do not use that proxy. Ollama is unauthenticated by default, so this can expose the local model API beyond the intended Docker Desktop/WSL route if Windows Firewall or equivalent host controls do not restrict LAN access.
    • Recommendation: Add a warning next to the Windows-host Ollama setup steps that this path intentionally binds Ollama for Docker Desktop/WSL reachability, does not use NemoClaw's authenticated proxy, and must be restricted to trusted Docker Desktop/WSL interfaces with Windows Firewall or equivalent host rules.
    • Evidence: `SKILL.md` says install and restart set `OLLAMA_HOST=0.0.0.0:11434`; later it says `WSL Ollama paths do not use this proxy. Windows-host Ollama uses the Windows daemon through host.docker.internal.` The troubleshooting section also suggests restarting Windows Ollama with `OLLAMA_HOST=0.0.0.0:11434` without a firewall caveat.
  • Security-sensitive inference eval coverage was collapsed to one broad prompt (skills/nemoclaw-user-configure-inference/evals/evals.json:1): The configure-inference eval suite now has one broad prompt with a generic expected behavior. The removed prompts were the focused checks most likely to catch regressions in provider credential handling, sandbox credential isolation, `inference.local` routing, sub-agent secret placement, runtime switching, rollback, and raw tool-call diagnostics.
    • Recommendation: Restore or replace focused evals for provider credential requirements, credentials staying outside the sandbox, `inference.local` gateway routing, Windows-host Ollama exposure guidance, sub-agent credential placement, runtime switching verification and rollback, and local tool-call leakage diagnostics.
    • Evidence: `evals/evals.json` now contains only `docs-inference-inference-options-001` with expected behavior `Uses the expected_skill and does not make up answers if it cannot find the answer from the skill.` The diff removes the targeted credential, routing, sub-agent, switch/rollback, and tool-calling eval entries.
  • Recovery and local-route claims still need behavior-specific source anchors (skills/nemoclaw-user-configure-inference/SKILL.md:219): The docs describe recovery and tolerant behavior in security-sensitive inference paths: restarting a stopped managed `nemoclaw-vllm` container after host reboot, reporting a failed sandbox `https://inference.local/v1/models\` runtime route before the first prompt, and rerunning onboarding to repair an unhealthy Ollama auth proxy. The PR does not identify the invalid-state source, source-fix constraint, behavior-specific regression coverage, or removal condition for each of these localized recovery paths.
    • Recommendation: Add or identify regression coverage and source-of-truth notes for each documented recovery path. At minimum, cover stopped managed-vLLM container restart after reboot, post-create Linux Docker-driver GPU `https://inference.local/v1/models\` validation before the first prompt, and rerun-onboarding repair when `Inference` is healthy but `Inference (auth proxy)` is unhealthy.
    • Evidence: `SKILL.md` states that NemoClaw restarts a stopped `nemoclaw-vllm` container during recovery, verifies `https://inference.local/v1/models\` from inside the sandbox runtime and reports recovery steps when it fails, and tells users to rerun onboarding when `Inference` is healthy but `Inference (auth proxy)` is not. Existing tests found partial proxy and inference.local probe coverage, but not behavior-specific anchors for all three documented recovery claims.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@github-actions

Copy link
Copy Markdown
Contributor

Selective E2E Results — ✅ All requested jobs passed

Run: 27296292530
Target ref: c3763cb07f84d4b917a6bb3bbadb923125aca71b
Workflow ref: main
Requested jobs: docs-validation-e2e
Summary: 1 passed, 0 failed, 0 skipped

Job Result
docs-validation-e2e ✅ success

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)
skills/nemoclaw-user-configure-inference/evals/evals.json (1)

1-1: ⚠️ Potential issue | 🟠 Major

Missing SPDX license header in skills/nemoclaw-user-configure-inference/evals/evals.json

  • The file content starts with [ and contains no SPDX header.
  • Repo-wide search found no // SPDX-... comment lines in any **/*.json files, so the required SPDX header is not being applied—either add it using // (and treat it as JSONC) or rename the file to .jsonc if strict JSON is required.
// SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-configure-inference/evals/evals.json` at line 1, The
file skills/nemoclaw-user-configure-inference/evals/evals.json is missing the
required SPDX license header; fix by either converting the file to JSONC (rename
to evals.jsonc) or by prepending the two SPDX comment lines as JSONC comments at
the very top of evals.json (e.g., add the two // SPDX-... lines shown in the
review) so the SPDX-FileCopyrightText and SPDX-License-Identifier are present
and recognized.

Source: Coding guidelines

skills/nemoclaw-user-reference/references/architecture.md (1)

1-1: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Missing SPDX license header.

All Markdown files must include an SPDX license header. As per coding guidelines, add the following at the top of the file:

<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
<!-- SPDX-License-Identifier: Apache-2.0 -->
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-reference/references/architecture.md` at line 1, Add the
required SPDX license header as the first two lines of the file before the
existing content (i.e., insert the exact lines <!-- SPDX-FileCopyrightText:
Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> and
<!-- SPDX-License-Identifier: Apache-2.0 -->) so the markdown starting with the
"# Architecture Details" heading includes the mandated license header at the
top.

Source: Coding guidelines

skills/nemoclaw-user-reference/references/troubleshooting.md (1)

1-1: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add required SPDX license header.

This Markdown file is missing the required SPDX license header. As per coding guidelines, all source files (including .md files) must include an SPDX header using HTML comment format.

📄 Proposed fix
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
+<!-- SPDX-License-Identifier: Apache-2.0 -->
+
 # Troubleshooting
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-reference/references/troubleshooting.md` at line 1, The
Markdown file starting with the "# Troubleshooting" heading is missing the
required SPDX license header; add an HTML comment SPDX header as the first lines
of the file (e.g. <!-- SPDX-License-Identifier: <LICENSE> -->) using the
repository's canonical license identifier, placing it before the "#
Troubleshooting" heading so the header is present in the file metadata.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/nemoclaw-user-configure-inference/SKILL.md`:
- Around line 1-5: Several Markdown docs in the PR are missing the required SPDX
header comments; add the two HTML SPDX lines exactly as specified (<!--
SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All
rights reserved. --> and <!-- SPDX-License-Identifier: Apache-2.0 -->)
immediately before the first top-level content (i.e., before the initial
YAML/frontmatter delimiter or first heading) in each Markdown file (for example
SKILL.md, tool-calling-reliability.md, set-up-sub-agent.md and the other .md
files in this change), preserving all existing content and headings.

---

Outside diff comments:
In `@skills/nemoclaw-user-configure-inference/evals/evals.json`:
- Line 1: The file skills/nemoclaw-user-configure-inference/evals/evals.json is
missing the required SPDX license header; fix by either converting the file to
JSONC (rename to evals.jsonc) or by prepending the two SPDX comment lines as
JSONC comments at the very top of evals.json (e.g., add the two // SPDX-...
lines shown in the review) so the SPDX-FileCopyrightText and
SPDX-License-Identifier are present and recognized.

In `@skills/nemoclaw-user-reference/references/architecture.md`:
- Line 1: Add the required SPDX license header as the first two lines of the
file before the existing content (i.e., insert the exact lines <!--
SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All
rights reserved. --> and <!-- SPDX-License-Identifier: Apache-2.0 -->) so the
markdown starting with the "# Architecture Details" heading includes the
mandated license header at the top.

In `@skills/nemoclaw-user-reference/references/troubleshooting.md`:
- Line 1: The Markdown file starting with the "# Troubleshooting" heading is
missing the required SPDX license header; add an HTML comment SPDX header as the
first lines of the file (e.g. <!-- SPDX-License-Identifier: <LICENSE> -->) using
the repository's canonical license identifier, placing it before the "#
Troubleshooting" heading so the header is present in the file metadata.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 32080812-e2e7-4bbb-91ce-faca29de9c8a

📥 Commits

Reviewing files that changed from the base of the PR and between 88a381e and c3763cb.

📒 Files selected for processing (12)
  • skills/nemoclaw-user-configure-inference/SKILL.md
  • skills/nemoclaw-user-configure-inference/evals/evals.json
  • skills/nemoclaw-user-configure-inference/references/inference-options.md
  • skills/nemoclaw-user-configure-inference/references/set-up-sub-agent.md
  • skills/nemoclaw-user-configure-inference/references/switch-inference-providers.md
  • skills/nemoclaw-user-configure-inference/references/tool-calling-reliability.md
  • skills/nemoclaw-user-configure-inference/references/use-local-inference-details.md
  • skills/nemoclaw-user-reference/SKILL.md
  • skills/nemoclaw-user-reference/references/architecture.md
  • skills/nemoclaw-user-reference/references/commands.md
  • skills/nemoclaw-user-reference/references/network-policies.md
  • skills/nemoclaw-user-reference/references/troubleshooting.md
💤 Files with no reviewable changes (1)
  • skills/nemoclaw-user-configure-inference/references/use-local-inference-details.md

Comment on lines 1 to 5
---
name: "nemoclaw-user-configure-inference"
description: "Connects NemoClaw to a local inference server. Use when setting up Ollama, vLLM, TensorRT-LLM, NIM, or any OpenAI-compatible local model server with NemoClaw. Trigger keywords - nemoclaw local inference, ollama nemoclaw, vllm nemoclaw, local model server, openai compatible endpoint, switch nemoclaw inference model, change inference runtime, nemoclaw additional model, nemoclaw sub-agent model, openclaw sub-agent, agents.list, sessions_spawn, vlm-demo, nemoclaw tool calling, ollama tool calls, vllm tool-call-parser, raw json in tui, nemoclaw inference options, nemoclaw onboarding providers, nemoclaw inference routing."
description: "Connects NemoClaw to a local inference server. Use when setting up Ollama, vLLM, TensorRT-LLM, NIM, or any OpenAI-compatible local model server with NemoClaw. Trigger keywords - nemoclaw local inference, ollama nemoclaw, vllm nemoclaw, local model server, openai compatible endpoint, switch nemoclaw inference model, change inference runtime, nemoclaw additional model, nemoclaw sub-agent model, openclaw sub-agent, agents.list, sessions_spawn, vlm-demo, nemoclaw inference options, nemoclaw onboarding providers, nemoclaw inference routing, nemoclaw tool calling, ollama tool calls, vllm tool-call-parser, raw json in tui."
license: "Apache-2.0"
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

All Markdown files are missing SPDX license headers.

Five Markdown documentation files in this PR lack the required SPDX headers. As per coding guidelines, all **/*.md files must include:

<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
<!-- SPDX-License-Identifier: Apache-2.0 -->

Place these comments before the first heading in each file. Note that the AI summaries for tool-calling-reliability.md and set-up-sub-agent.md explicitly mention the SPDX header "was removed," but the coding guidelines require it to be present.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-configure-inference/SKILL.md` around lines 1 - 5,
Several Markdown docs in the PR are missing the required SPDX header comments;
add the two HTML SPDX lines exactly as specified (<!-- SPDX-FileCopyrightText:
Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> and
<!-- SPDX-License-Identifier: Apache-2.0 -->) immediately before the first
top-level content (i.e., before the initial YAML/frontmatter delimiter or first
heading) in each Markdown file (for example SKILL.md,
tool-calling-reliability.md, set-up-sub-agent.md and the other .md files in this
change), preserving all existing content and headings.

Source: Coding guidelines

@cv cv added the v0.0.64 Release target label Jun 11, 2026
@cv

cv commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cv

cv commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
skills/nemoclaw-user-configure-inference/SKILL.md (1)

1-5: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add the SPDX header before the frontmatter.

This Markdown file still lacks the required SPDX HTML comments at the top; frontmatter alone does not satisfy the repo-wide license-header rule.

Suggested placement
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
+<!-- SPDX-License-Identifier: Apache-2.0 -->
 ---
 name: "nemoclaw-user-configure-inference"

As per coding guidelines, all **/*.md files must include the SPDX HTML comments before the first heading/frontmatter.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-configure-inference/SKILL.md` around lines 1 - 5, Add
the required SPDX license HTML comment header before the existing YAML
frontmatter in SKILL.md: insert the SPDX HTML comment (e.g. <!--
SPDX-FileCopyrightText: ... --> and <!-- SPDX-License-Identifier: Apache-2.0
-->) immediately at the top of the file before the leading '---' so the SPDX
header precedes the frontmatter and satisfies the repo-wide license-header rule.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@skills/nemoclaw-user-configure-inference/SKILL.md`:
- Around line 1-5: Add the required SPDX license HTML comment header before the
existing YAML frontmatter in SKILL.md: insert the SPDX HTML comment (e.g. <!--
SPDX-FileCopyrightText: ... --> and <!-- SPDX-License-Identifier: Apache-2.0
-->) immediately at the top of the file before the leading '---' so the SPDX
header precedes the frontmatter and satisfies the repo-wide license-header rule.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a82db495-c4c0-4f33-ac14-6ae13a94b39b

📥 Commits

Reviewing files that changed from the base of the PR and between c3763cb and d87ed9e.

📒 Files selected for processing (2)
  • skills/nemoclaw-user-configure-inference/SKILL.md
  • skills/nemoclaw-user-configure-inference/skill-card.md
💤 Files with no reviewable changes (1)
  • skills/nemoclaw-user-configure-inference/skill-card.md

@cv

cv commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions

Copy link
Copy Markdown
Contributor

Selective E2E Results — ✅ All requested jobs passed

Run: 27388151925
Target ref: 92ffbc3c1a68acb4568effd67a914e7d5144f9fd
Workflow ref: main
Requested jobs: docs-validation-e2e
Summary: 1 passed, 0 failed, 0 cancelled, 0 skipped

Job Result
docs-validation-e2e ✅ success

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
skills/nemoclaw-user-configure-inference/SKILL.md (1)

1-1: ⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Missing SPDX license headers (flagged in prior review).

Both published skills/nemoclaw-user-configure-inference/SKILL.md and the autogenerated .agents/ version are missing required SPDX headers. Per coding guidelines, all Markdown files must include the SPDX header comments before the YAML frontmatter.

🔧 Proposed fix: Add SPDX headers to both files

For skills/nemoclaw-user-configure-inference/SKILL.md:

+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
+<!-- SPDX-License-Identifier: Apache-2.0 -->
 ---
 name: "nemoclaw-user-configure-inference"

For .agents/skills/nemoclaw-user-configure-inference/SKILL.md, apply the same fix. Note: Since the .agents/ file is autogenerated by docs-to-skills.py, you will need to ensure the source docs/ file also includes the SPDX headers so they regenerate correctly in the .agents/ copy.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-configure-inference/SKILL.md` at line 1, Both SKILL
markdown files are missing the required SPDX license header; add the SPDX header
comment line(s) (e.g., <!-- SPDX-License-Identifier: MIT --> or the appropriate
license identifier) immediately before the YAML frontmatter in
skills/nemoclaw-user-configure-inference/SKILL.md and ensure the same header
appears in .agents/skills/nemoclaw-user-configure-inference/SKILL.md by updating
the source docs/ file that docs-to-skills.py uses so the autogenerated copy
includes the header; verify the header is placed above the leading ---
frontmatter and not inside it.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@skills/nemoclaw-user-configure-inference/SKILL.md`:
- Line 1: Both SKILL markdown files are missing the required SPDX license
header; add the SPDX header comment line(s) (e.g., <!-- SPDX-License-Identifier:
MIT --> or the appropriate license identifier) immediately before the YAML
frontmatter in skills/nemoclaw-user-configure-inference/SKILL.md and ensure the
same header appears in .agents/skills/nemoclaw-user-configure-inference/SKILL.md
by updating the source docs/ file that docs-to-skills.py uses so the
autogenerated copy includes the header; verify the header is placed above the
leading --- frontmatter and not inside it.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 791ec661-3af5-49fa-9e56-e6e5e4de0029

📥 Commits

Reviewing files that changed from the base of the PR and between d87ed9e and 92ffbc3.

📒 Files selected for processing (2)
  • .agents/skills/nemoclaw-user-configure-inference/SKILL.md
  • skills/nemoclaw-user-configure-inference/SKILL.md

@cv

cv commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cv cv merged commit fa09629 into main Jun 12, 2026
33 checks passed
@cv cv deleted the codex/refresh-managed-vllm-skills branch June 12, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Documentation, examples, guides, or docs build area: skills Skills, agent behaviors, prompts, or skill packaging v0.0.64 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants