docs(skills): refresh managed-vLLM catalog skills#5162
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughConsolidates and expands NemoClaw documentation for inference configuration, provider onboarding, runtime model switching, CLI commands, architecture, and troubleshooting with OpenClaw/Hermes-specific guidance. ChangesInference Configuration Consolidation and Provider Guidance
CLI Commands and Environment Variable Reference Expansion
Deployment Architecture, Runtime Context, and Network Policies
Enhanced Troubleshooting and Platform-Specific Guidance
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
PR Review AdvisorFindings: 0 needs attention, 6 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
Selective E2E Results — ✅ All requested jobs passedRun: 27296292530
|
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
skills/nemoclaw-user-configure-inference/evals/evals.json (1)
1-1:⚠️ Potential issue | 🟠 MajorMissing SPDX license header in
skills/nemoclaw-user-configure-inference/evals/evals.json
- The file content starts with
[and contains no SPDX header.- Repo-wide search found no
// SPDX-...comment lines in any**/*.jsonfiles, so the required SPDX header is not being applied—either add it using//(and treat it as JSONC) or rename the file to.jsoncif strict JSON is required.// SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. // SPDX-License-Identifier: Apache-2.0🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemoclaw-user-configure-inference/evals/evals.json` at line 1, The file skills/nemoclaw-user-configure-inference/evals/evals.json is missing the required SPDX license header; fix by either converting the file to JSONC (rename to evals.jsonc) or by prepending the two SPDX comment lines as JSONC comments at the very top of evals.json (e.g., add the two // SPDX-... lines shown in the review) so the SPDX-FileCopyrightText and SPDX-License-Identifier are present and recognized.Source: Coding guidelines
skills/nemoclaw-user-reference/references/architecture.md (1)
1-1:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winMissing SPDX license header.
All Markdown files must include an SPDX license header. As per coding guidelines, add the following at the top of the file:
<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> <!-- SPDX-License-Identifier: Apache-2.0 -->🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemoclaw-user-reference/references/architecture.md` at line 1, Add the required SPDX license header as the first two lines of the file before the existing content (i.e., insert the exact lines <!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> and <!-- SPDX-License-Identifier: Apache-2.0 -->) so the markdown starting with the "# Architecture Details" heading includes the mandated license header at the top.Source: Coding guidelines
skills/nemoclaw-user-reference/references/troubleshooting.md (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd required SPDX license header.
This Markdown file is missing the required SPDX license header. As per coding guidelines, all source files (including
.mdfiles) must include an SPDX header using HTML comment format.📄 Proposed fix
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> +<!-- SPDX-License-Identifier: Apache-2.0 --> + # Troubleshooting🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemoclaw-user-reference/references/troubleshooting.md` at line 1, The Markdown file starting with the "# Troubleshooting" heading is missing the required SPDX license header; add an HTML comment SPDX header as the first lines of the file (e.g. <!-- SPDX-License-Identifier: <LICENSE> -->) using the repository's canonical license identifier, placing it before the "# Troubleshooting" heading so the header is present in the file metadata.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/nemoclaw-user-configure-inference/SKILL.md`:
- Around line 1-5: Several Markdown docs in the PR are missing the required SPDX
header comments; add the two HTML SPDX lines exactly as specified (<!--
SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All
rights reserved. --> and <!-- SPDX-License-Identifier: Apache-2.0 -->)
immediately before the first top-level content (i.e., before the initial
YAML/frontmatter delimiter or first heading) in each Markdown file (for example
SKILL.md, tool-calling-reliability.md, set-up-sub-agent.md and the other .md
files in this change), preserving all existing content and headings.
---
Outside diff comments:
In `@skills/nemoclaw-user-configure-inference/evals/evals.json`:
- Line 1: The file skills/nemoclaw-user-configure-inference/evals/evals.json is
missing the required SPDX license header; fix by either converting the file to
JSONC (rename to evals.jsonc) or by prepending the two SPDX comment lines as
JSONC comments at the very top of evals.json (e.g., add the two // SPDX-...
lines shown in the review) so the SPDX-FileCopyrightText and
SPDX-License-Identifier are present and recognized.
In `@skills/nemoclaw-user-reference/references/architecture.md`:
- Line 1: Add the required SPDX license header as the first two lines of the
file before the existing content (i.e., insert the exact lines <!--
SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All
rights reserved. --> and <!-- SPDX-License-Identifier: Apache-2.0 -->) so the
markdown starting with the "# Architecture Details" heading includes the
mandated license header at the top.
In `@skills/nemoclaw-user-reference/references/troubleshooting.md`:
- Line 1: The Markdown file starting with the "# Troubleshooting" heading is
missing the required SPDX license header; add an HTML comment SPDX header as the
first lines of the file (e.g. <!-- SPDX-License-Identifier: <LICENSE> -->) using
the repository's canonical license identifier, placing it before the "#
Troubleshooting" heading so the header is present in the file metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 32080812-e2e7-4bbb-91ce-faca29de9c8a
📒 Files selected for processing (12)
skills/nemoclaw-user-configure-inference/SKILL.mdskills/nemoclaw-user-configure-inference/evals/evals.jsonskills/nemoclaw-user-configure-inference/references/inference-options.mdskills/nemoclaw-user-configure-inference/references/set-up-sub-agent.mdskills/nemoclaw-user-configure-inference/references/switch-inference-providers.mdskills/nemoclaw-user-configure-inference/references/tool-calling-reliability.mdskills/nemoclaw-user-configure-inference/references/use-local-inference-details.mdskills/nemoclaw-user-reference/SKILL.mdskills/nemoclaw-user-reference/references/architecture.mdskills/nemoclaw-user-reference/references/commands.mdskills/nemoclaw-user-reference/references/network-policies.mdskills/nemoclaw-user-reference/references/troubleshooting.md
💤 Files with no reviewable changes (1)
- skills/nemoclaw-user-configure-inference/references/use-local-inference-details.md
| --- | ||
| name: "nemoclaw-user-configure-inference" | ||
| description: "Connects NemoClaw to a local inference server. Use when setting up Ollama, vLLM, TensorRT-LLM, NIM, or any OpenAI-compatible local model server with NemoClaw. Trigger keywords - nemoclaw local inference, ollama nemoclaw, vllm nemoclaw, local model server, openai compatible endpoint, switch nemoclaw inference model, change inference runtime, nemoclaw additional model, nemoclaw sub-agent model, openclaw sub-agent, agents.list, sessions_spawn, vlm-demo, nemoclaw tool calling, ollama tool calls, vllm tool-call-parser, raw json in tui, nemoclaw inference options, nemoclaw onboarding providers, nemoclaw inference routing." | ||
| description: "Connects NemoClaw to a local inference server. Use when setting up Ollama, vLLM, TensorRT-LLM, NIM, or any OpenAI-compatible local model server with NemoClaw. Trigger keywords - nemoclaw local inference, ollama nemoclaw, vllm nemoclaw, local model server, openai compatible endpoint, switch nemoclaw inference model, change inference runtime, nemoclaw additional model, nemoclaw sub-agent model, openclaw sub-agent, agents.list, sessions_spawn, vlm-demo, nemoclaw inference options, nemoclaw onboarding providers, nemoclaw inference routing, nemoclaw tool calling, ollama tool calls, vllm tool-call-parser, raw json in tui." | ||
| license: "Apache-2.0" | ||
| --- |
There was a problem hiding this comment.
All Markdown files are missing SPDX license headers.
Five Markdown documentation files in this PR lack the required SPDX headers. As per coding guidelines, all **/*.md files must include:
<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. -->
<!-- SPDX-License-Identifier: Apache-2.0 -->Place these comments before the first heading in each file. Note that the AI summaries for tool-calling-reliability.md and set-up-sub-agent.md explicitly mention the SPDX header "was removed," but the coding guidelines require it to be present.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/nemoclaw-user-configure-inference/SKILL.md` around lines 1 - 5,
Several Markdown docs in the PR are missing the required SPDX header comments;
add the two HTML SPDX lines exactly as specified (<!-- SPDX-FileCopyrightText:
Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> and
<!-- SPDX-License-Identifier: Apache-2.0 -->) immediately before the first
top-level content (i.e., before the initial YAML/frontmatter delimiter or first
heading) in each Markdown file (for example SKILL.md,
tool-calling-reliability.md, set-up-sub-agent.md and the other .md files in this
change), preserving all existing content and headings.
Source: Coding guidelines
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
♻️ Duplicate comments (1)
skills/nemoclaw-user-configure-inference/SKILL.md (1)
1-5:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAdd the SPDX header before the frontmatter.
This Markdown file still lacks the required SPDX HTML comments at the top; frontmatter alone does not satisfy the repo-wide license-header rule.
Suggested placement
+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> +<!-- SPDX-License-Identifier: Apache-2.0 --> --- name: "nemoclaw-user-configure-inference"As per coding guidelines, all
**/*.mdfiles must include the SPDX HTML comments before the first heading/frontmatter.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemoclaw-user-configure-inference/SKILL.md` around lines 1 - 5, Add the required SPDX license HTML comment header before the existing YAML frontmatter in SKILL.md: insert the SPDX HTML comment (e.g. <!-- SPDX-FileCopyrightText: ... --> and <!-- SPDX-License-Identifier: Apache-2.0 -->) immediately at the top of the file before the leading '---' so the SPDX header precedes the frontmatter and satisfies the repo-wide license-header rule.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@skills/nemoclaw-user-configure-inference/SKILL.md`:
- Around line 1-5: Add the required SPDX license HTML comment header before the
existing YAML frontmatter in SKILL.md: insert the SPDX HTML comment (e.g. <!--
SPDX-FileCopyrightText: ... --> and <!-- SPDX-License-Identifier: Apache-2.0
-->) immediately at the top of the file before the leading '---' so the SPDX
header precedes the frontmatter and satisfies the repo-wide license-header rule.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a82db495-c4c0-4f33-ac14-6ae13a94b39b
📒 Files selected for processing (2)
skills/nemoclaw-user-configure-inference/SKILL.mdskills/nemoclaw-user-configure-inference/skill-card.md
💤 Files with no reviewable changes (1)
- skills/nemoclaw-user-configure-inference/skill-card.md
|
@coderabbitai review |
✅ Action performedReview finished.
|
Selective E2E Results — ✅ All requested jobs passedRun: 27388151925
|
There was a problem hiding this comment.
♻️ Duplicate comments (1)
skills/nemoclaw-user-configure-inference/SKILL.md (1)
1-1:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winMissing SPDX license headers (flagged in prior review).
Both published
skills/nemoclaw-user-configure-inference/SKILL.mdand the autogenerated.agents/version are missing required SPDX headers. Per coding guidelines, all Markdown files must include the SPDX header comments before the YAML frontmatter.🔧 Proposed fix: Add SPDX headers to both files
For
skills/nemoclaw-user-configure-inference/SKILL.md:+<!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> +<!-- SPDX-License-Identifier: Apache-2.0 --> --- name: "nemoclaw-user-configure-inference"For
.agents/skills/nemoclaw-user-configure-inference/SKILL.md, apply the same fix. Note: Since the.agents/file is autogenerated bydocs-to-skills.py, you will need to ensure the sourcedocs/file also includes the SPDX headers so they regenerate correctly in the.agents/copy.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemoclaw-user-configure-inference/SKILL.md` at line 1, Both SKILL markdown files are missing the required SPDX license header; add the SPDX header comment line(s) (e.g., <!-- SPDX-License-Identifier: MIT --> or the appropriate license identifier) immediately before the YAML frontmatter in skills/nemoclaw-user-configure-inference/SKILL.md and ensure the same header appears in .agents/skills/nemoclaw-user-configure-inference/SKILL.md by updating the source docs/ file that docs-to-skills.py uses so the autogenerated copy includes the header; verify the header is placed above the leading --- frontmatter and not inside it.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@skills/nemoclaw-user-configure-inference/SKILL.md`:
- Line 1: Both SKILL markdown files are missing the required SPDX license
header; add the SPDX header comment line(s) (e.g., <!-- SPDX-License-Identifier:
MIT --> or the appropriate license identifier) immediately before the YAML
frontmatter in skills/nemoclaw-user-configure-inference/SKILL.md and ensure the
same header appears in .agents/skills/nemoclaw-user-configure-inference/SKILL.md
by updating the source docs/ file that docs-to-skills.py uses so the
autogenerated copy includes the header; verify the header is placed above the
leading --- frontmatter and not inside it.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 791ec661-3af5-49fa-9e56-e6e5e4de0029
📒 Files selected for processing (2)
.agents/skills/nemoclaw-user-configure-inference/SKILL.mdskills/nemoclaw-user-configure-inference/SKILL.md
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Refreshes the published catalog copies of the generated inference and reference user skills so they match the source
.agents/skillsoutput after #5038. This addresses the review advisor finding that the rootskills/packages still had stale managed-vLLM defaults and override slugs.Related Issue
Follow-up to #5038; addresses #5038 (comment).
Changes
skills/nemoclaw-user-configure-inferencefrom the generated.agentssource while preserving catalog-only metadata and signing artifacts.skills/nemoclaw-user-referencefrom the generated.agentssource while preserving catalog-only metadata and signing artifacts.qwen3.6-35b-a3b-nvfp4/nvidia/Qwen3.6-35B-A3B-NVFP4, DGX Station asqwen3.6-27b/Qwen/Qwen3.6-27B-FP8, generic Linux asnemotron-3-nano-4b/nvidia/NVIDIA-Nemotron-3-Nano-4B-FP8, and thedeepseek-v4-flashoverride slug.use-local-inference-details.mdreference file because the current generated inference skill carries that content inreferences/inference-options.md.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)npm run docscompleted with 0 errors, but Fern reported two pre-existing/environmental warnings: unauthenticated redirects check skipped, and a light-mode accent contrast warning.Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit