test(e2e): migrate test-diagnostics.sh to vitest#5347
Conversation
Reserve Phase 4 E2E migration work for test-diagnostics.sh. Refs #5098
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a new Changesdiagnostics-vitest E2E scenario
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
PR Review AdvisorFindings: 0 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
This is an automated advisory review. A human maintainer must make the final merge decision. |
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27438057992
|
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27445950567
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27447165043
|
# Conflicts: # tools/e2e-scenarios/free-standing-jobs.env
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27448996355
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27451481008
|
# Conflicts: # tools/e2e-scenarios/free-standing-jobs.env
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27452009591
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27452769626
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27455028803
|
…to e2e-migrate/test-diagnostics
…to e2e-migrate/test-diagnostics
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27457002233
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27457432807
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27459111478
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27459961487
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27461469324
|
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the branch is 96%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the branch is 46%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
Updated |
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27462517963
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27463570996
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27464207573
|
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27594970645
|
Summary
Migrate
test/e2e/test-diagnostics.shwith the simplest equivalent live Vitest coverage.Legacy shell deletion and nightly shell lane retirement are deferred to #5098 Phase 11; this PR adds the replacement Vitest path beside the stable legacy lane.
Related Issues
Refs #5098
Contract mapping
nemoclaw --versionexits 0 and prints semver.test/e2e-scenario/live/diagnostics.test.tsruns the repo CLI entrypoint and asserts semver output.nemoclaw debug --quick --outputcreates a non-empty archive within the quick timeout.debug --quick --outputand checks archive existence/size/time.nemoclaw debug --outputcreates an extractable tarball with no NVIDIA credential leaks.nvapi-*patterns.tar, archive extraction, credential scanning.--sandboxsucceeds while unknown--sandboxfails, names the sandbox, reportsnot registered, and writes no partial tarball.openclaw.jsonis readable and host status shows model/provider diagnostics.nemoclaw <sandbox> status.credentials listhides values andcredentials resetremoves the provider credential.nvidia-prodwhen present.Simplicity check
nightly-e2e.yamljobdiagnostics-e2eviae2e-script.yaml, defaultubuntu-latest, Docker/OpenShell,NVIDIA_API_KEY,NEMOCLAW_RECREATE_SANDBOX=1, 45-minute reusable timeout.ubuntu-latestrunner class with Docker/OpenShell andNVIDIA_API_KEYine2e-vitest-scenarios.yamljobdiagnostics-vitest.diagnostics.test.ts.e2e-vitest-scenarios.yamlwithjobs=diagnostics-vitestorscenarios=diagnostics.Verification
npm ci --ignore-scriptsnpm run build:clinpm run typecheck:cliNEMOCLAW_RUN_E2E_SCENARIOS=1 npx vitest run test/e2e-scenario/live/diagnostics.test.ts --project e2e-scenarios-live(local no-secret run skips with evidence)npx vitest run test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts --project e2e-vitest-supportgit diff --checkorigin/main; support workflow test re-ran locally after refresh.workflow_dispatch,jobs=diagnostics-vitest) — passedSummary by CodeRabbit
Tests
Chores