test(e2e): migrate test-concurrent-gateway-ports.sh to vitest#5349
test(e2e): migrate test-concurrent-gateway-ports.sh to vitest#5349jyaunches wants to merge 7 commits into
Conversation
Reserve Phase 4 E2E migration work for test-concurrent-gateway-ports.sh. Refs #5098
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughAdds a new live Vitest E2E scenario ( Changesconcurrent-gateway-ports E2E scenario
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
PR Review AdvisorFindings: 0 needs attention, 5 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
…urrent-gateway-ports
…urrent-gateway-ports
…urrent-gateway-ports
…urrent-gateway-ports
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the branch is 96%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the branch is 46%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
Updated |
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27594971597
|
Summary
Migrate
test/e2e/test-concurrent-gateway-ports.shwith focused live Vitest coverage.Related Issues
Refs #5098
Contract mapping
8080) and default dashboard port (18789).test/e2e-scenario/live/concurrent-gateway-ports.test.tsruns the repo CLI against a fake OpenAI-compatible endpoint and asserts sandbox A reaches Ready/Running,nemoclaw listreports dashboard port18789, and the host gateway port is listening.NEMOCLAW_GATEWAY_PORTset to a non-default port.NEMOCLAW_GATEWAY_PORT=18080and checks the per-port OpenShell gateway namenemoclaw-18080.nemoclaw listincludes both sandboxes, and the dashboard ports are distinct.nemoclaw list, and hostsssocket observation.nemoclaw <sandbox> destroy --yesand OpenShell state.Simplicity check
nightly-e2e.yamljobconcurrent-gateway-ports-e2eviae2e-script.yaml, defaultubuntu-latest, Docker/OpenShell, fake OpenAI-compatible endpoint, 30 minute reusable timeout.ubuntu-latestrunner class ine2e-vitest-scenarios.yamljobconcurrent-gateway-ports-vitest, with Docker Hub auth, OpenShell install, CLI build, and 90 minute timeout for two live onboards.e2e-vitest-scenarios.yamlwithjobs=concurrent-gateway-ports-viteston this PR branch.Verification
npm run build:clinpx biome check --write test/e2e-scenario/live/concurrent-gateway-ports.test.ts test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts tools/e2e-scenarios/workflow-boundary.mtsnpx vitest run --project e2e-vitest-support test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts --silent=false --reporter=defaultgit diff --checkworkflow_dispatch,jobs=concurrent-gateway-ports-vitest) — passedSigned-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Tests