test(e2e): update Discord proxy expectation by sandl99 · Pull Request #5391 · NVIDIA/NemoClaw

sandl99 · 2026-06-13T17:16:39Z

Summary

Updates the messaging providers E2E M9b assertion so Discord now expects channels.discord.accounts.default.proxy to match the sandbox proxy while the top-level managed proxy remains configured. This aligns the test with the Discord proxy behavior restored by PR #5248 for issue #5075.

Changes

Updated test/e2e/test-messaging-providers.sh M9b comments and pass/fail messages to describe per-account Discord proxy routing.
Changed the M9b assertion to require both account.proxy and proxy.proxyUrl to equal the expected sandbox proxy URL.
Reviewed docs/ and found no user-facing docs update needed because this is a stale E2E expectation change with no product behavior change.

Type of Change

Code change (feature, bug fix, or refactor)
Code change with doc updates
Doc only (prose changes, no code sample modifications)
Doc only (includes code sample changes)

Verification

npx prek run --all-files passes
npm test passes
Tests added or updated for new or changed behavior
No secrets, API keys, or credentials committed
Docs updated for user-facing behavior changes
npm run docs builds without warnings (doc changes only)
Doc pages follow the style guide (doc changes only)
New doc pages include SPDX header and frontmatter (new pages only)

Additional verification:

bash -n test/e2e/test-messaging-providers.sh passed.
shellcheck test/e2e/test-messaging-providers.sh passed.
npx prek run --files test/e2e/test-messaging-providers.sh passed.
npx vitest run --project cli test/discord-template-resolver-proxy.test.ts test/generate-openclaw-config.test.ts passed.
Docs review completed: no docs changes needed.
Full npx prek run --all-files and npm test were attempted and fail in unrelated existing suites outside this change.

Signed-off-by: San Dang sdang@nvidia.com

Summary by CodeRabbit

Tests
- Updated Discord proxy configuration validation in end-to-end tests to reflect current proxy-wiring expectations during configuration patching.

Signed-off-by: San Dang <sdang@nvidia.com>

coderabbitai · 2026-06-13T17:16:52Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e85bcc55-8582-4e02-b55c-ae939906ef41

📥 Commits

Reviewing files that changed from the base of the PR and between 158f575 and 503c3b1.

📒 Files selected for processing (1)

test/e2e/test-messaging-providers.sh

📝 Walkthrough

Walkthrough

This PR updates the Discord proxy-wiring test assertion in an end-to-end test script. The test now validates that both the per-account proxy configuration and the top-level managed proxy URL are set to the expected managed proxy value, instead of allowing the per-account proxy to remain empty.

Changes

Discord Proxy-Wiring Assertion

Layer / File(s)	Summary
M9b Discord proxy-wiring assertion and validation `test/e2e/test-messaging-providers.sh`	Updated the comment and validation logic for Discord gateway routing to expect both `account.proxy` and `proxy.proxyUrl` to be set to the computed `expected_managed_proxy`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

NVIDIA/NemoClaw#5248: Both PRs adjust Discord proxy wiring to ensure the generated Discord per-account account.proxy is set to the expected managed/sandbox proxy URL (not left empty/undefined), aligning resolver output and test assertions.

Suggested labels

integration: discord, area: messaging, nightly-e2e, bug-fix

Poem

🐰 A proxy now sets both its places,
Account and platform, matching faces,
The Discord thread now holds them tight,
Per-account and managed, both in sight.
Where routing once stayed incomplete,
Now proxy wiring is all neat! 🔗

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title concisely describes the main change: updating Discord proxy expectations in an E2E test, which directly matches the file modified and the core objective.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/messaging-e2e-discord-proxy-expectation

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-code-quality · 2026-06-13T17:17:29Z

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in the fix/messaging-e2e-di... branch is 96%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.

File	main	fix/messaging-e2e-di... `503c3b1`	+/-
`nemoclaw/src/se...cret-scanner.ts`	—	100%	—
`nemoclaw/src/commands/slash.ts`	—	100%	—
`nemoclaw/src/li...bprocess-env.ts`	—	100%	—
`nemoclaw/src/bl...eprint/state.ts`	—	98%	—
`nemoclaw/src/onboard/config.ts`	—	98%	—
`nemoclaw/src/bl...int/snapshot.ts`	—	97%	—
`nemoclaw/src/bl...print/runner.ts`	—	95%	—
`nemoclaw/src/co...ration-state.ts`	—	94%	—
`nemoclaw/src/bl...ate-networks.ts`	—	94%	—
`nemoclaw/src/index.ts`	—	94%	—

TypeScript / code-coverage/cli

The overall coverage in the fix/messaging-e2e-di... branch is 44%. Coverage data for the main branch is not yet available.

Show a code coverage summary of the most covered files.

File	main	fix/messaging-e2e-di... `503c3b1`	+/-
`src/lib/state/o...oard-session.ts`	—	90%	—
`src/lib/inference/local.ts`	—	77%	—
`src/lib/sandbox/config.ts`	—	72%	—
`src/lib/inference/nim.ts`	—	72%	—
`src/lib/onboard/preflight.ts`	—	64%	—
`src/lib/state/sandbox.ts`	—	55%	—
`src/lib/onboard...er-gpu-patch.ts`	—	50%	—
`src/lib/actions...licy-channel.ts`	—	49%	—
`src/lib/policy/index.ts`	—	48%	—
`src/lib/onboard.ts`	—	17%	—

_{Updated June 13, 2026 17:19 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

github-actions · 2026-06-13T17:17:51Z

E2E Advisor Recommendation

Required E2E: None
Optional E2E: messaging-providers-e2e

Dispatch hint: messaging-providers-e2e

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

None.

Optional E2E

messaging-providers-e2e (75 minute timeout): Optional validation for the exact changed shell E2E script. This job exercises the Telegram/Discord/Slack messaging provider credential placeholder and proxy chain, including the edited Discord M9b proxy assertion, but should not be merge-blocking because the PR is tests-only.

New E2E recommendations

None.

Dispatch hint

Workflow: .github/workflows/nightly-e2e.yaml
jobs input: messaging-providers-e2e

github-actions · 2026-06-13T17:17:52Z

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: None
Optional Vitest E2E scenarios: None

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required Vitest E2E scenarios

None. The only changed file is outside the Vitest scenario system (test/e2e-scenario/) and does not modify .github/workflows/e2e-vitest-scenarios.yaml or other directly scenario-relevant Vitest E2E machinery, so no Vitest scenario dispatch is recommended.

Optional Vitest E2E scenarios

None.

Relevant changed files

None.

github-actions · 2026-06-13T17:18:34Z

PR Review Advisor

Findings: 0 needs attention, 0 worth checking, 1 nice ideas
Top item: Align stale M13 Discord proxy wording

Review findings

🛠️ Needs attention

None.

🔎 Worth checking

None.

🌱 Nice ideas

Align stale M13 Discord proxy wording with the per-account proxy expectation (test/e2e/test-messaging-providers.sh:2406): The updated M9b block now says Discord Gateway routing depends on the per-account proxy, which matches the current Discord manifest and template resolver. A nearby M13d-config comment still says Discord should rely on the top-level proxy config instead of a per-account proxy, which can confuse future debugging about what the E2E proof is validating.
- Recommendation: Consider updating the M13b-M13g comment/pass/fail wording to say it exercises the same sandbox proxy URL through OpenShell, without implying Discord is top-level-proxy-only.
- Evidence: M9b now requires `channels.discord.accounts.default.proxy` and `proxy.proxyUrl` to equal `expected_managed_proxy`; nearby lines 2406-2409 still describe the proof as using the generated managed proxy URL and top-level proxy config.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

github-actions · 2026-06-13T17:20:24Z

Selective E2E Results — ❌ Some jobs failed

Run: 27473654902
Target ref: fix/messaging-e2e-discord-proxy-expectation
Requested jobs: messaging-providers-e2e
Summary: 0 passed, 1 failed, 0 cancelled, 0 skipped

Job	Result
messaging-providers-e2e	❌ failure

Failed jobs: messaging-providers-e2e. Check run artifacts for logs.

sandl99 · 2026-06-13T17:27:22Z

@cv fix messaging-provider-e2e stale after #5248 got checked in, but it still failed due to inference change

test(e2e): update Discord proxy expectation

503c3b1

Signed-off-by: San Dang <sdang@nvidia.com>

sandl99 self-assigned this Jun 13, 2026

sandl99 requested a review from cv June 13, 2026 17:26

cv approved these changes Jun 13, 2026

View reviewed changes

cv merged commit 1457ef3 into main Jun 13, 2026
117 of 121 checks passed

cv deleted the fix/messaging-e2e-discord-proxy-expectation branch June 13, 2026 17:31

cv added the v0.0.65 Release target label Jun 15, 2026

Conversation

sandl99 commented Jun 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Type of Change

Verification

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

github-code-quality Bot commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

TypeScript / code-coverage/plugin

TypeScript / code-coverage/cli

Uh oh!

github-actions Bot commented Jun 13, 2026

E2E Advisor Recommendation

E2E Recommendation Advisor

Required E2E

Optional E2E

New E2E recommendations

Dispatch hint

Uh oh!

github-actions Bot commented Jun 13, 2026

Vitest E2E Scenario Recommendation

Vitest E2E Scenario Advisor

Required Vitest E2E scenarios

Optional Vitest E2E scenarios

Relevant changed files

Uh oh!

github-actions Bot commented Jun 13, 2026

PR Review Advisor

🛠️ Needs attention

🔎 Worth checking

🌱 Nice ideas

Uh oh!

github-actions Bot commented Jun 13, 2026

Selective E2E Results — ❌ Some jobs failed

Uh oh!

sandl99 commented Jun 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sandl99 commented Jun 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 13, 2026 •

edited

Loading

github-code-quality Bot commented Jun 13, 2026 •

edited

Loading