docs: point remaining "Quickstart with Hermes" links at the Hermes quickstart#5394
docs: point remaining "Quickstart with Hermes" links at the Hermes quickstart#5394harjothkhara wants to merge 1 commit into
Conversation
…ickstart Three more pages had a "Quickstart with Hermes" link pointing at the OpenClaw quickstart source file (../get-started/quickstart) instead of the Hermes quickstart (../get-started/quickstart-hermes). Fern resolves relative links by source-file path, so these resolved to the wrong page. Each sits in a Hermes-only context (a variant="hermes" block or the Hermes ecosystem page); the sibling OpenClaw links are correct and left untouched. - docs/about/ecosystem-hermes.mdx - docs/manage-sandboxes/lifecycle.mdx - docs/inference/use-local-inference.mdx (two occurrences) Add a regression test. Completes the broken-link class also addressed in Signed-off-by: harjoth <harjoth.khara@gmail.com> NVIDIA#5392 (NVIDIA#5076) and NVIDIA#5393 (NVIDIA#5079, NVIDIA#5089).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR corrects documentation links across four pages to ensure "Quickstart with Hermes" references point to the Hermes-specific quickstart page ( ChangesHermes Quickstart Documentation Links
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Closing this. It built on the same premise as #5392/#5393, and the underlying issues (#5076/#5079/#5089) were all closed as not-planned (docs-link validation false positives). Inside the hermes variant block, |
Summary
Three more documentation pages had a "Quickstart with Hermes" link pointing at the OpenClaw quickstart source file (
../get-started/quickstart) instead of the Hermes quickstart (../get-started/quickstart-hermes). Fern resolves relative[](…)links by source-file path, so these resolved to the wrong page. Each occurrence is in a Hermes-only context; the sibling OpenClaw links are correct and left untouched.This completes the broken-internal-link cleanup also addressed in #5392 (#5076) and #5393 (#5079, #5089), and follows the same approach as the earlier link sweep in #4665.
Changes
docs/about/ecosystem-hermes.mdx— Hermes ecosystem page.docs/manage-sandboxes/lifecycle.mdx—variant="hermes"block (thevariant="openclaw"block keeps../get-started/quickstart).docs/inference/use-local-inference.mdx— twovariant="hermes"blocks (OpenClaw blocks unchanged).test/repro-hermes-quickstart-links.test.tsasserting the corrected targets and that the OpenClaw links are preserved.Type of Change
test/Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Verified locally: the Hermes quickstart target source file exists;
scripts/docs-to-skills.py … --dry-runsucceeds; the new regression test's assertions pass. The fullprek/npm test/npm run docssuite was not run locally; leaving those for CI.Signed-off-by: harjoth harjoth.khara@gmail.com
Summary by CodeRabbit
Documentation
Tests