test(e2e): migrate cloud onboard flow to Vitest#5494
Merged
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new live E2E Vitest test ( ChangesCloud Onboard Live E2E Scenario
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
Contributor
PR Review AdvisorFindings: 2 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the branch is 96%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the branch is 46%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
Updated |
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27629700449
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/e2e-scenario/live/cloud-onboard.test.ts`:
- Around line 45-64: The cleanup function is suppressing all errors from both
the host cleanup command and the sandbox gateway destroy operation by catching
and ignoring exceptions with .catch(() => undefined). This allows tests to pass
even when cleanup or verification fails, violating the scenario's contract to
verify sandbox removal. Remove the .catch(() => undefined) error suppression
handlers from both the host command (which runs cleanup.sh with --verify flag)
and the sandbox openshell gateway destroy call, so that any cleanup or
verification failures will properly propagate and cause the test to fail.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 35cc94c6-ef38-4d31-9758-e00b1d580e9c
📒 Files selected for processing (2)
.github/workflows/e2e-vitest-scenarios.yamltest/e2e-scenario/live/cloud-onboard.test.ts
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27635622848
|
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27636903903
|
…d-onboard-e2e # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27638941300
|
…d-onboard-e2e # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
test-cloud-onboard-e2e.shinto the live Vitest E2E system. Addstest/e2e-scenario/live/cloud-onboard.test.tsandcloud-onboard-vitestworkflow wiring. The Vitest test drives the public curl installer from the requested Git ref, verifies the installed CLI/OpenShell path, then runs the split cloud check scripts for inference.local, security, and Landlock/read-only behavior before cleanup.Related Issue
Refs #5098
Changes
cloud-onboard.cloud-onboard-vitestin.github/workflows/e2e-vitest-scenarios.yaml.test-cloud-onboard-e2e.shwhile leaving legacy shell retirement to Epic: Migrate legacy bash E2E into the Vitest E2E system #5098 Phase 11.Type of Change
Verification
npx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Targeted local checks run while preparing these branches:
npx vitest run --project e2e-vitest-support test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts --silent=false --reporter=defaultnpm run typecheck:clifor branches adding new TypeScript testsgit diff --checkSelective same-runner dispatch: https://github.com/NVIDIA/NemoClaw/actions/runs/27638941300 — passed after merge-from-main refresh
Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Tests
CI / Automation