test(e2e): migrate scope upgrade approval to Vitest#5498
Open
cv wants to merge 11 commits into
Open
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new TypeScript Vitest live E2E test for the issue-4462 scope-upgrade approval scenario, replacing the prior shell-based test. The test embeds a bash/Python script that validates scope-upgrade approval flows and absence of ChangesScope-upgrade approval Vitest migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
E2E Advisor RecommendationRequired E2E: None Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
Contributor
PR Review AdvisorFindings: 3 needs attention, 4 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the branch is 96%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the branch is 46%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
Updated |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27629709761
|
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27630405507
|
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27631165609
|
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27631676124
|
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27633396676
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/e2e-vitest-scenarios.yaml:
- Around line 1822-1840: The NVIDIA_INFERENCE_API_KEY environment variable in
the "Run issue-4462-scope-upgrade-approval live Vitest test" job is
inconsistently sourced from secrets.NVIDIA_API_KEY, while all other occurrences
throughout the workflow use secrets.NVIDIA_INFERENCE_API_KEY. Update the env
section for this job to source NVIDIA_INFERENCE_API_KEY from
secrets.NVIDIA_INFERENCE_API_KEY to maintain consistency with the rest of the
workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 81c266e9-91f7-4ec8-93b7-327d627cdbd6
📒 Files selected for processing (2)
.github/workflows/e2e-vitest-scenarios.yamltest/e2e-scenario/live/issue-4462-scope-upgrade-approval.test.ts
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27635628747
|
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27636908661
|
…e-4462-scope-upgrade-approval # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27638947760
|
…e-4462-scope-upgrade-approval # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml
…e-4462-scope-upgrade-approval # Conflicts: # .github/workflows/e2e-vitest-scenarios.yaml
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27649248534
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
test-issue-4462-scope-upgrade-approval.shinto the live Vitest E2E system. Addstest/e2e-scenario/live/issue-4462-scope-upgrade-approval.test.tsandissue-4462-scope-upgrade-approval-vitestworkflow wiring. The Vitest test installs a real sandbox, verifies the proxy-env devices-approve guard, approves or observes the CLI scope upgrade without operator.admin, and confirms a final agent turn stays on the gateway path.Related Issue
Refs #5098
Changes
issue-4462-scope-upgrade-approval.issue-4462-scope-upgrade-approval-vitestin.github/workflows/e2e-vitest-scenarios.yaml.test-issue-4462-scope-upgrade-approval.shwhile leaving legacy shell retirement to Epic: Migrate legacy bash E2E into the Vitest E2E system #5098 Phase 11.Type of Change
Verification
npx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Targeted local checks run while preparing these branches:
npx vitest run --project e2e-vitest-support test/e2e-scenario/support-tests/e2e-scenarios-workflow.test.ts --silent=false --reporter=defaultnpm run typecheck:clifor branches adding new TypeScript testsgit diff --checkSelective same-runner dispatch: https://github.com/NVIDIA/NemoClaw/actions/runs/27649248534 — passed after merge-from-main refresh
Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit