fix(security): require explicit opt-in for Telegram bridge open chat access#699
Draft
fix(security): require explicit opt-in for Telegram bridge open chat access#699
Conversation
…access When ALLOWED_CHAT_IDS is unset, the bridge now refuses to start unless ALLOW_ALL_CHATS=true is explicitly set. This changes the default from open-access to fail-closed, preventing arbitrary Telegram users from driving the sandboxed agent without operator intent. Addresses NVBUG 6007062.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft — seeking feedback on approach before finalizing.
The Telegram bridge silently accepts messages from ALL chats when
ALLOWED_CHAT_IDSis unset. This PR adds a visible warning and logs new chat IDs so users can build their allowlist, without breaking existing deployments.Behavior:
ALLOWED_CHAT_IDS, noALLOW_ALL_CHATS: Bridge starts with a loud warning; logs each new chat ID + username so the user can copy-paste intoALLOWED_CHAT_IDSALLOW_ALL_CHATS=true: Brief warning, no per-message logging (explicit opt-in)ALLOWED_CHAT_IDSset: Existing filtering, no warnings, no changeOpen question
Should we hard-fail instead of warn? Current approach is non-breaking but the bridge still accepts all messages. The alternative (exit with error) is more secure but breaks every existing Telegram bridge deployment that doesn't have
ALLOWED_CHAT_IDSset.Test plan
ALLOWED_CHAT_IDSandALLOW_ALL_CHATSALLOW_ALL_CHATS=true→ verify brief warning onlyALLOWED_CHAT_IDS→ verify no warnings