fix(sbom): detect sha256 hashes in expression-form licenses in needs_fix#1911
Open
mesutoezdil wants to merge 1 commit into
Open
fix(sbom): detect sha256 hashes in expression-form licenses in needs_fix#1911mesutoezdil wants to merge 1 commit into
mesutoezdil wants to merge 1 commit into
Conversation
CycloneDX allows licenses as either {"license": {"id": "..."}} or
{"expression": "..."}. needs_fix only checked the license form, so
expression entries with sha256 hashes were silently skipped.
Add expression-form check to needs_fix, mirroring the fix in
extract_licenses (NVIDIA#1898). Add tests covering both forms.
mesutoezdil
requested review from
a team,
derekwaynecarr and
mrunalp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CycloneDX allows licenses in 2 forms:
{"license": {"id": "MIT"}}// handled correctly{"expression": "MIT OR Apache-2.0"}// not checked inneeds_fixneeds_fixonly looked at thelicensekey, so components with a sha256 hash in expression form were silently skipped and never resolved.This is the parallel fix to #1898, which fixed the same gap in
extract_licenses. Adds tests covering both forms.