refactor(proto): rename UpdateSettings to UpdateConfig for consistency with read path#515
Merged
johntmyers merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
pimlock
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the
UpdateSettingsRPC toUpdateConfigto match the read-side naming (GetSandboxConfig,GetGatewayConfig). The RPC handles both settings and policy mutations, soUpdateConfigis more accurate.Related Issue
Follow-up to #474 (PR review feedback)
Changes
UpdateSettings→UpdateConfig,UpdateSettingsRequest/Response→UpdateConfigRequest/Responseupdate_settings→update_configMechanical rename across 17 files, no behavioral changes.
Testing
cargo buildall affected cratescargo test -p openshell-server -p openshell-coreall passingChecklist