Skip to content

target/arm/kvm: check get_msi_direct_gpa before &address_space_memory guard #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmhonap wants to merge 1 commit into from
Closed

target/arm/kvm: check get_msi_direct_gpa before &address_space_memory guard #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions target/arm/kvm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1634,22 +1634,23 @@ int kvm_arch_fixup_msi_route(struct kvm_irq_routing_entry *route,
MemoryRegionSection mrs;
MemoryRegion *mr;

if (as == &address_space_memory) {
return 0;
}

/*
* We do have an IOMMU address space, but for some vIOMMU implementations
* (e.g. accelerated SMMUv3) the translation tables are programmed into
* the physical SMMUv3 in the host (nested S1=guest, S2=host). QEMU cannot
* walk these tables in a safe way, so in that case we obtain the MSI
* doorbell GPA directly from the vIOMMU backend and ignore the gIOVA
* @address.
* @address. For such devices pci_device_iommu_address_space() returns
* &address_space_memory, so this check must precede the early-exit below.
*/
if (pci_device_iommu_msi_direct_gpa(dev, &doorbell_gpa)) {
goto set_doorbell;
}

if (as == &address_space_memory) {
return 0;
}

/* MSI doorbell address is translated by an IOMMU */

rcu_read_lock();
Expand Down