Skip to content

Conversation

@jberchtold-nvidia
Copy link
Collaborator

@jberchtold-nvidia jberchtold-nvidia commented Jan 15, 2026

Description

Expand the troubleshooting installation docs with a few recently debugged issues.
image

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Expand troubleshooting docs to add some recently debugged issues, including with uv venvs and JAX-specific issue symptoms.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 15, 2026

Greptile Summary

This PR expands the troubleshooting documentation in README.rst by adding three new sections covering recently debugged installation issues:

  • UV/Virtual Environment Issues: Documents common problems when using uv or virtual environments, including import errors, cuDNN sublibrary loading failures, and wheel building issues
  • JAX-specific Issues: Addresses FFI registration errors that occur when build isolation is not disabled during installation

The new content follows the existing documentation structure with symptom/solution pairs and provides actionable guidance for users experiencing these issues. The documentation additions are straightforward and helpful for users encountering these specific problems.

Confidence Score: 4/5

  • This documentation-only PR is safe to merge with minimal risk
  • The changes are purely additive to troubleshooting documentation with no code changes. Minor formatting inconsistencies (extra blank lines, hardcoded Python version) noted in previous review comments don't impact the utility or safety of merging
  • No files require special attention

Important Files Changed

Filename Overview
README.rst Added troubleshooting sections for UV/venv issues and JAX FFI errors with minor formatting inconsistencies

Sequence Diagram

sequenceDiagram
    participant User
    participant README as README.rst
    participant Docs as Troubleshooting Docs
    
    User->>README: Encounters installation issue
    README->>Docs: Check Troubleshooting section
    
    alt UV/Virtual Environment Issue
        Docs->>User: Check "Problems using UV or Virtual Environments"
        User->>Docs: Review Import Error solution
        User->>Docs: Review cuDNN Loading Failed solution
        User->>Docs: Review Building Wheels solution
    else JAX-specific Issue
        Docs->>User: Check "JAX-specific Common Issues"
        User->>Docs: Review FFI Issues solution
        Note over User,Docs: Recommends --no-build-isolation flag
    else Other Build Issue
        Docs->>User: Check existing troubleshooting sections
        User->>Docs: Review compiler, headers, or build resource issues
    end
    
    User->>User: Apply solution with proper flags/environment variables
    User->>User: Successfully install TransformerEngine
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

jberchtold-nvidia and others added 2 commits January 15, 2026 09:53
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: jberchtold-nvidia <158520091+jberchtold-nvidia@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: jberchtold-nvidia <158520091+jberchtold-nvidia@users.noreply.github.com>
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile


.. code-block:: bash
export CUDNN_PATH=$(pwd)/.venv/lib/python3.12/site-packages/nvidia/cudnn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: hardcoded Python version may not work for all users - consider using a generic placeholder like pythonX.Y or explaining users should adjust this

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment on lines +318 to +319


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: extra blank line - RST should have only one blank line before code blocks (see lines 305-306 for consistent formatting)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Signed-off-by: jberchtold-nvidia <158520091+jberchtold-nvidia@users.noreply.github.com>
@jberchtold-nvidia
Copy link
Collaborator Author

/te-ci

@jberchtold-nvidia jberchtold-nvidia added the documentation Improvements or additions to documentation label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant