Make signature CI pull-request aware#229
Merged
Merged
Conversation
Contributor
|
👋 Thank you for your contribution! This pull request is from a forked repository so GitHub Actions will not be able to run CI. A maintainer will review your changes shortly and manually trigger the CI. @maintainers Please review this PR when you have a chance and follow the instructions in the CONTRIBUTING.md file to trigger the CI. |
robobryce
force-pushed
the
fix/signature-pr-base
branch
from
July 25, 2026 10:28
c320bdf to
ecd77e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainpull-request/<number>mirror branchesRoot cause
PRs based on
event/2026-07-cscs-summer-schoolinherited commits that are not onmain. The oldorigin/main..HEADcomparison treated those inherited commits as PR commits, so #227 checked 40 commits and failed on 21 unsigned event-branch commits even though its own commit was validly signed.Validation
pull-request/<number>mirror, new branch, non-PR push, deleted branch, truncated payload, and API-failure pathsc23ec73...2f3250cas exactly one commityamllinton both workflowsgithub-scriptblocksgit diff --check