[cudax] Change the group mapping application logic#8755
Open
davebayer wants to merge 3 commits intoNVIDIA:mainfrom
Open
[cudax] Change the group mapping application logic#8755davebayer wants to merge 3 commits intoNVIDIA:mainfrom
davebayer wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Contributor
🥳 CI Workflow Results🟩 Finished in 33m 23s: Pass: 100%/54 | Total: 5h 59m | Max: 32m 53s | Hits: 97%/31859See results here. |
pciolkosz
approved these changes
May 2, 2026
Contributor
pciolkosz
left a comment
pciolkosz
left a comment
There was a problem hiding this comment.
A bit confused on the testing, but the tests pass, so it probably just confusion and I will approve
| @@ -33,11 +33,12 @@ __device__ void test_lane_synchronizer(const Level& level, Config config) | |||
| // Test make_instance(...). | |||
| { | |||
| const auto parent_group = cudax::make_this_group(level, config); | |||
| const ThreadsInWarpMappingResult prev_mapping_result; | |||
Contributor
There was a problem hiding this comment.
I don't get why is this always thread in warp mapping, while the parent varies. Applies in other tests too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way mappings are applied during the mapping phase of group creation. I found out it would be better if the mappings worked as transformers that take the previous mapping result and return a modified mapping result. This is a step towards allowing combining multiple mappings together to produce 1 group.