Add transfer inference control-CFG and per-hint defaults#16
Open
trungtpham wants to merge 3 commits into
Open
Conversation
Wire control_guidance through args, inference routing, and OmniMoTModel; expose transfer hints on sample args with tuned per-control defaults and control_path-only specs; load JSON prompts and negative captions for transfer.
trungtpham
force-pushed
the
feature/transfer-control-guidance
branch
from
0c7b571 to
24d78b9
Compare
foreverlms
reviewed
Jun 4, 2026
| dummy_sa = sample_args_list[0].model_copy( | ||
| update={"output_dir": None, "name": "padding", "num_steps": 1, "guidance": 1.0} | ||
| ) | ||
| dummy_sa = sample_args_list[0].model_copy(update={"output_dir": None, "name": "padding"}) |
Collaborator
There was a problem hiding this comment.
Why is this reverted? The previous change is for reduce potential computation redundancy.
foreverlms
reviewed
Jun 4, 2026
| config = None | ||
| else: | ||
| model_dict = setup_args.load_model_config_dict() | ||
| if setup_args.vlm_processor_from_checkpoint: |
Collaborator
There was a problem hiding this comment.
Why is this removed? this is for cosmos-nano-test-to-image series models.
foreverlms
reviewed
Jun 4, 2026
| revision="main", | ||
| ), | ||
| ), | ||
| # Task-specialized Super variants published as diffusers HF checkpoints. |
Collaborator
|
@trungtpham Seems that we need first rebase on some newest features from the current main like @foreverlms noted. Currently seems that some new features are occasionally reverted. THX! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
control_guidance, optional interval) to sampling args andOmniMoTModel.generate_samples_from_batch, including a no-control branch for multi-vision transfer samples.OmniInference: dedicated batch path (batch size 1), skip genericget_sample_datawhen transfer hints are set, pass control-CFG throughgenerate_transfer_sample.SampleData(edge/blur/depth/seg/wsm),_TRANSFER_DEFAULTS(guidance, control_guidance, shift; WSM 101f @ 10 fps), and control-only specs viacontrol_pathwithoutvision_path.negative_prompt_fileonly for transfer specs.Test plan
torchrun -m cosmos_framework.scripts.inferencewithspecs/edge.jsonon Cosmos3-Nano (--no-guardrails).control_guidance != 1.0runs without fallback warning when control + target vision items are present.control_pathonly.