Skip to content

Un-disable ruff E722 Do not use bare except#1347

Merged
kkraus14 merged 3 commits into
NVIDIA:mainfrom
rwgk:no_bare_except
Dec 10, 2025
Merged

Un-disable ruff E722 Do not use bare except#1347
kkraus14 merged 3 commits into
NVIDIA:mainfrom
rwgk:no_bare_except

Conversation

@rwgk

@rwgk rwgk commented Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Remove E722 from [lint.per-file-ignores] in ruff.toml
  2. Fix one bare except error in test_cufile.py
  3. It turns out the skip condition in cuda_bindings/examples/3_CUDA_Features/simpleCudaGraphs_test.py is not needed in our CI testing.

@copy-pr-bot

copy-pr-bot Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk

rwgk commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@rwgk rwgk marked this pull request as ready for review December 9, 2025 18:09
@copy-pr-bot

copy-pr-bot Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk rwgk requested a review from leofang December 9, 2025 18:10
@rwgk

rwgk commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

@leofang Can you think of a situation in which the skip condition in cuda_bindings/examples/3_CUDA_Features/simpleCudaGraphs_test.py is needed?

@leofang

leofang commented Dec 9, 2025

Copy link
Copy Markdown
Member

It is needed in CUDA 12.x wheels, where the needed headers are splayed into different paths under site-packages. This is not caught in the CI because we don't run cuda-bindings 12.x tests on main. But I think it is OK to removed it from main, now that this issue is fixed with CUDA 13.x.

@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do test Improvements or additions to tests cuda.bindings Everything related to the cuda.bindings module labels Dec 10, 2025
@leofang leofang added this to the cuda-python 13-next, 12-next milestone Dec 10, 2025
@kkraus14 kkraus14 added the to-be-backported Trigger the bot to raise a backport PR upon merge label Dec 10, 2025
@kkraus14 kkraus14 merged commit 514daa6 into NVIDIA:main Dec 10, 2025
161 of 162 checks passed
@github-actions

github-actions Bot commented Dec 10, 2025

Copy link
Copy Markdown

Backport failed for 12.9.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 12.9.x
git worktree add -d .worktree/backport-1347-to-12.9.x origin/12.9.x
cd .worktree/backport-1347-to-12.9.x
git switch --create backport-1347-to-12.9.x
git cherry-pick -x 514daa6c0d95aae26d028faaf92097d5f37311b7

@github-actions

github-actions Bot commented Dec 10, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang modified the milestones: cuda.bindings 13.1.2 & 12.9.6, cuda.bindings next Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@leofang leofang leofang approved these changes

Assignees

@rwgk rwgk

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do test Improvements or additions to tests to-be-backported Trigger the bot to raise a backport PR upon merge

Projects

None yet

Milestone

cuda.bindings 13.2.0 & 12.9.6

Development

Successfully merging this pull request may close these issues.

3 participants

@rwgk @leofang @kkraus14