Move supports_ipc_mempool to cuda_core-specific helpers
#1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move supports_ipc_mempool from cuda_python_test_helpers to cuda_core/tests/helpers/__init__.py to remove the dependency on cuda_python_test_helpers for this CUDA-specific functionality. This makes cuda_python_test_helpers independent of CUDA-specific packages, allowing it to be used in other contexts without requiring cuda-core or cuda-bindings to be installed. Changes: - Add supports_ipc_mempool to cuda_core/tests/helpers/__init__.py - Update cuda_core/tests/test_memory.py to import from helpers - Remove supports_ipc_mempool from cuda_python_test_helpers - Remove unused imports (functools, Union, handle_return) from cuda_python_test_helpers
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rwgk
changed the title
supports_ipc_mempool to cuda_core-specific helperssupports_ipc_mempool to cuda_core-specific helpers
Collaborator
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Andy-Jost
approved these changes
Jan 12, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
supports_ipc_mempoolfromcuda_python_test_helperstocuda_core/tests/helpers/__init__.pyto remove the dependency oncuda_python_test_helpersfor this cuda-core-specific functionality.This makes
cuda_python_test_helpersindependent of cuda-core-specific packages, allowing it to be used in other contexts without requiringcuda-coreorcuda-bindingsto be installed.Changes:
supports_ipc_mempooltocuda_core/tests/helpers/__init__.pycuda_core/tests/test_memory.pyto import fromhelperssupports_ipc_mempoolfromcuda_python_test_helpersfunctools,Union,handle_return) fromcuda_python_test_helpersNote: This PR was extracted from PR #1454