Add Nvfatbin Bindings#1467
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
leofang
added
P0
|
FYI @rparolin all of these are generated code except for the tests. There is an internal MR targeting the codegen for this. |
| if err != nvrtc.nvrtcResult.NVRTC_SUCCESS: | ||
| raise RuntimeError(repr(err)) | ||
|
|
||
| err, program_handle = nvrtc.nvrtcCreateProgram(CODE.encode(), b"", 0, [], []) |
There was a problem hiding this comment.
Not a blocker for this PR, but I think we have some helper functions for NVRTC that can be used in cuda-bindings tests, so that we do not have to reimplement them in this file.
There was a problem hiding this comment.
Agreed, I saw this pattern showed up in test_nvjitlink as well. Perhaps a shared fixture that returns an nvrtc artifact.
leofang
added
the
to-be-backported
|
/ok to test 8e75d8a |
This comment has been minimized.
This comment has been minimized.
|
/ok to test 965c53b |
Need to skip the tile IR test for nvFatbin < 13.1 |
This shows in some CI environment there's nvcc installed but it's not properly setup due to missing host compiler. |
|
/ok to test 4baeecd |
|
/ok to test 4c2f3f3 |
Yup! See #1467 (comment). |
| [project.optional-dependencies] | ||
| all = [ | ||
| "cuda-toolkit[nvrtc,nvjitlink,nvvm]==13.*", | ||
| "cuda-toolkit[nvrtc,nvjitlink,nvvm,nvfatbin]==13.*", |
There was a problem hiding this comment.
@kkraus14 this minds me a discussion we had a few months ago -- One day installing cuda-binding[all] would bring in the whole CTK 😂
|
LGTM! Thanks, @isVoid! |
|
/ok to test 3e071e2 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 12.9.x
git worktree add -d .worktree/backport-1467-to-12.9.x origin/12.9.x
cd .worktree/backport-1467-to-12.9.x
git switch --create backport-1467-to-12.9.x
git cherry-pick -x 1af5db98e2f39a11c3ebd82190ca63156e052a09 |
|
* initial localized test * add rest of APIs * remove local skips * regenerate for CUDA 13.1 and with tile IR API * nvfatbinError -> nvFatbinError * regenerate for get_error_string * enable object creation and testing * remove the LTOIR mismatching arch failure test * encode a legal tileIR into test * update the license year * add an embedded tile program for re-generation * license date: 2026 * cdef const char * * add dependency for CI * add TODO to locate nvcc file * add documentation and release notes * skip tileIR test for <13.1 installation * add an nvcc smoke test to better determine compiler usability * fix typo * add nvfatbin.rst --------- Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>
* initial localized test * add rest of APIs * remove local skips * regenerate for CUDA 13.1 and with tile IR API * nvfatbinError -> nvFatbinError * regenerate for get_error_string * enable object creation and testing * remove the LTOIR mismatching arch failure test * encode a legal tileIR into test * update the license year * add an embedded tile program for re-generation * license date: 2026 * cdef const char * * add dependency for CI * add TODO to locate nvcc file * add documentation and release notes * skip tileIR test for <13.1 installation * add an nvcc smoke test to better determine compiler usability * fix typo * add nvfatbin.rst --------- Co-authored-by: Michael Wang <isVoid@users.noreply.github.com>
4 participants
Description
closes #156
Checklist