Skip to content

pathfinder: support cusolverMp dynamic loading and header searching#1845

Merged
rwgk merged 9 commits into
NVIDIA:mainfrom
yangcal:pathfinder-cusolverMp
Apr 1, 2026
Merged

pathfinder: support cusolverMp dynamic loading and header searching#1845
rwgk merged 9 commits into
NVIDIA:mainfrom
yangcal:pathfinder-cusolverMp

Conversation

@yangcal

@yangcal yangcal commented Apr 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR enables pathfinder to be able to dynamically load cusolverMp as well as find the headers. It is needed for nvmath-python to support cusolverMp bindings

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@carterbox

carterbox commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

@rwgk

rwgk
rwgk reviewed Apr 1, 2026
View reviewed changes
Comment thread cuda_pathfinder/cuda/pathfinder/_dynamic_libs/descriptor_catalog.py Outdated
Comment thread cuda_pathfinder/cuda/pathfinder/_headers/header_descriptor_catalog.py Outdated
@rwgk rwgk added this to the cuda.pathfinder next milestone Apr 1, 2026
@rwgk rwgk added enhancement Any code-related improvements P0 High priority - Must do! cuda.pathfinder Everything related to the cuda.pathfinder module labels Apr 1, 2026
rwgk
rwgk approved these changes Apr 1, 2026
View reviewed changes

@rwgk rwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yangcal!

@rwgk

rwgk commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

/ok to test 3e45960

@rwgk rwgk enabled auto-merge (squash) April 1, 2026 18:34
@github-actions

This comment has been minimized.

Sign in to view
@rwgk

rwgk commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

The Windows "all_must_work" tests aren't happy. I'm taking a look. (I have a Windows machine handy.)

auto-merge was automatically disabled April 1, 2026 20:53

Head branch was pushed to by a user without write access

@yangcal

yangcal commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

@rwgk The failure may be due to a miss in available_on_windows=False for the headers. updated in 4087a47

@rwgk

rwgk commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

@rwgk The failure may be due to a miss in available_on_windows=False for the headers. updated in 4087a47

That's it, thanks! I tested locally on my Windows machine. I'll re-trigger the CI.

@rwgk

rwgk commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

/ok to test b5bb1e9

@rwgk rwgk enabled auto-merge (squash) April 1, 2026 21:04
@rwgk

rwgk commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

The CI / Test linux-64 / py3.12, 12.9.1, local, l4 failures is an infrastructure flake. I'll rerun when the all other jobs are finished.

@rwgk rwgk merged commit 6211c5a into NVIDIA:main Apr 1, 2026
167 of 170 checks passed
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@yangcal yangcal deleted the pathfinder-cusolverMp branch April 2, 2026 15:46
@yangcal

yangcal commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

@rwgk thanks for reviewing and merging this PR. Any idea when the next pathfinder release will be? nvmath-python is hoping to use pathfinder to dynamic load cusolverMp for the bindings

@rwgk

rwgk commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

@yangcal I can make a release tomorrow morning. — I was hoping to squeeze in something else, but it's turning out significantly more difficult than I was hoping; so I'll just make a 1.5.1 release with what we have right now.

@yangcal

yangcal commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

wow that's fast. Thanks

@rwgk

rwgk commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Released with https://github.com/NVIDIA/cuda-python/releases/tag/cuda-pathfinder-v1.5.1 just now.

@yangcal

yangcal commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

thanks for the quick action 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

Assignees

@yangcal yangcal

Labels

cuda.pathfinder Everything related to the cuda.pathfinder module enhancement Any code-related improvements P0 High priority - Must do!

Projects

None yet

Milestone

cuda.pathfinder next

Development

Successfully merging this pull request may close these issues.

3 participants

@yangcal @carterbox @rwgk