Skip to content

Fix #2019: Move Python-compatibility shims to their own file #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkraus14 merged 2 commits into from
May 14, 2026
Merged

Fix #2019: Move Python-compatibility shims to their own file #2078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba3b5da
Fix #2019: Move Python-compatibility shims to their own file
mdboom May 13, 2026
ced3b0c
Move _pycompat -> _utils.pycompat
mdboom May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions cuda_core/cuda/core/_memory/_buffer.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,7 @@ from cuda.core._utils.cuda_utils cimport HANDLE_RETURN, _parse_fill_value
import sys
from typing import TypeVar

if sys.version_info >= (3, 12):
from collections.abc import Buffer as BufferProtocol
else:
BufferProtocol = object

from cuda.core._utils.pycompat import BufferProtocol
from cuda.core._dlpack import classify_dl_device, make_py_capsule
from cuda.core._device import Device

Expand Down
23 changes: 23 additions & 0 deletions cuda_core/cuda/core/_utils/pycompat.py
View file
Open in desktop

@leofang leofang May 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Move this to cuda/core/_utils?

Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# SPDX-License-Identifier: Apache-2.0

"""
Compatibility shims for differences between supported Python versions.
"""

import sys

__all__ = ["BufferProtocol", "StrEnum"]


if sys.version_info >= (3, 11):
from enum import StrEnum
else:
from backports.strenum import StrEnum


if sys.version_info >= (3, 12):
from collections.abc import Buffer as BufferProtocol
else:
BufferProtocol = object
10 changes: 2 additions & 8 deletions cuda_core/cuda/core/system/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,7 @@
#
# SPDX-License-Identifier: Apache-2.0

import sys

if sys.version_info >= (3, 11):
from enum import StrEnum
else:
from backports.strenum import StrEnum

from cuda.core._utils.pycompat import StrEnum

__all__ = [
"AddressingMode",
Expand Down Expand Up @@ -364,4 +358,4 @@ class DeviceArch(_FastEnum):
pass


del StrEnum, sys
del StrEnum
Loading