Skip to content

Exclude NVSHMEM 3.7.0 from pathfinder test dependencies and fix rlcompleter test #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwgk merged 2 commits into from
Jun 11, 2026
+5 −3
Merged

Exclude NVSHMEM 3.7.0 from pathfinder test dependencies and fix rlcompleter test #2199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4614df7
Exclude NVSHMEM 3.7.0
rwgk Jun 11, 2026
3553f8a
Skip test on recent Pythons
mdboom Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cuda_core/tests/test_rlcompleter_patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ def test_patched_completion_succeeds_on_non_ipc_resource():
assert "allocation_handle: True" in result.stdout, result.stdout


@pytest.mark.skipif(sys.version_info >= (3, 15), reason="Python 3.15 fixed the rlcompleter bug upstream")
@pytest.mark.skipif(
sys.version_info >= (3, 13), reason="Python 3.13.13, 3.14.6 and 3.15 fixed the rlcompleter bug upstream"
)
def test_opt_out_env_var_disables_patch_even_when_interactive():
"""`CUDA_CORE_DONT_FIX_TAB_COMPLETION=1` must short-circuit before the
interactive check, so the bug reproduces again even under PYTHONINSPECT."""
Expand Down
4 changes: 2 additions & 2 deletions cuda_pathfinder/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ cu12 = [
"nvidia-cusparselt-cu12",
"nvidia-libmathdx-cu12",
"nvidia-nccl-cu12; sys_platform != 'win32'",
"nvidia-nvshmem-cu12; sys_platform != 'win32'",
"nvidia-nvshmem-cu12!=3.7.0; sys_platform != 'win32'",
]
cu13 = [
"cuda-toolkit[nvcc,cublas,nvrtc,cudart,cufft,curand,cusolver,cusparse,npp,nvfatbin,nvjitlink,nvjpeg,cccl,cupti,profiler,nvvm]==13.*",
Expand All @@ -43,7 +43,7 @@ cu13 = [
"nvidia-cusparselt-cu13",
"nvidia-libmathdx-cu13",
"nvidia-nccl-cu13; sys_platform != 'win32'",
"nvidia-nvshmem-cu13; sys_platform != 'win32'",
"nvidia-nvshmem-cu13!=3.7.0; sys_platform != 'win32'",
]
host = [
# TODO: remove the Python 3.15 guard once 3.15 is officially supported
Expand Down
Loading