Skip to content

Backport #1972 to 12.9.x#2206

Merged
mdboom merged 5 commits into
NVIDIA:12.9.xfrom
mdboom:cybind-catchup-12.9.x
Jun 17, 2026
Merged

Backport #1972 to 12.9.x#2206
mdboom merged 5 commits into
NVIDIA:12.9.xfrom
mdboom:cybind-catchup-12.9.x

Conversation

@mdboom

@mdboom mdboom commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

…IDIA#1972)

* Move driver and nvrtc cython and internal layers to new generator

* Fix Cython interop tests

* Handle headers differently

* Fix compilation

* Make const match

* Fix compilation again

* Attempt to fix Windows build

* Fix Windows again

* Fix not found error code

* Look up pointers in a different way

* Get first version right

* Get first appearing versions correct

* Fix weird special case

* Fix exception signature to match what was there before

* Also fix exception declaration in nvrtc

* Fix PTDS and add PTDS testing

* Update .gitignore

Co-authored-by: Leo Fang <leof@nvidia.com>

---------

Co-authored-by: Leo Fang <leof@nvidia.com>
@github-actions github-actions Bot added the cuda.bindings Everything related to the cuda.bindings module label Jun 12, 2026
@mdboom mdboom added this to the cuda.bindings next milestone Jun 12, 2026
@leofang

leofang commented Jun 15, 2026

Copy link
Copy Markdown
Member

@mdboom Does this reflect the final changes you made in #1972?

@leofang leofang added enhancement Any code-related improvements P0 High priority - Must do! labels Jun 15, 2026
@leofang leofang self-requested a review June 15, 2026 16:09
@mdboom

mdboom commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

@mdboom Does this reflect the final changes you made in #1972?

Yes. Unfortunately, a bunch of things broke when not running through all of the headers in cybind (as would happen when trying to regenerate this). I'm close to a fix, but I should have done this work before merging #1972 because it turns out this backport use case is a lot harder than I expected.

@mdboom

mdboom commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Testing here seems to be broken by #2226.

@leofang: Check out the generator-side changes required for this one to understand better what went wrong here.

@mdboom

mdboom commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@leofang: This is passing now and ready for review.

@mdboom mdboom enabled auto-merge (squash) June 16, 2026 13:43

@leofang leofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport — same symbol-loading checks pass as #1972, no 13.x APIs leaked in.

-- Leo's bot

@mdboom mdboom merged commit fd4810c into NVIDIA:12.9.x Jun 17, 2026
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants