Skip to content

Fix performance hint warnings raised by Cython 3#538

Merged
leofang merged 8 commits into
NVIDIA:mainfrom
leofang:fix_warning
Apr 4, 2025
Merged

Fix performance hint warnings raised by Cython 3#538
leofang merged 8 commits into
NVIDIA:mainfrom
leofang:fix_warning

Conversation

@leofang

@leofang leofang commented Mar 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • For changes in nvJitLink/NVVM, please see internal codegen (MR 110)
  • For changes in cudart, please see internal codegen (MR 41)

@leofang leofang added this to the cuda-python 12.9.0 & 11.8.7 milestone Mar 29, 2025
@leofang leofang self-assigned this Mar 29, 2025
@copy-pr-bot

copy-pr-bot Bot commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang changed the title WIP: Fix performance hit warnings raised by Cython 3 Fix performance hit warnings raised by Cython 3 Apr 1, 2025
@leofang leofang marked this pull request as ready for review April 1, 2025 04:42
@leofang leofang requested review from rwgk and vzhurba01 April 1, 2025 04:42
@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module labels Apr 1, 2025
@leofang

leofang commented Apr 1, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@leofang leofang changed the title Fix performance hit warnings raised by Cython 3 Fix performance hint warnings raised by Cython 3 Apr 1, 2025
leofang
leofang commented Apr 1, 2025
View reviewed changes
Comment thread cuda_bindings/docs/source/release/12.X.Y-notes.rst Outdated
vzhurba01
vzhurba01 previously approved these changes Apr 1, 2025
View reviewed changes
rwgk
rwgk reviewed Apr 1, 2025
View reviewed changes
Comment thread cuda_bindings/cuda/bindings/nvvm.pyx Outdated
kkraus14
kkraus14 previously approved these changes Apr 2, 2025
View reviewed changes
@leofang

leofang commented Apr 4, 2025

Copy link
Copy Markdown
Member Author

/ok to test

@leofang

leofang commented Apr 4, 2025

Copy link
Copy Markdown
Member Author

Admin-merge since it's been approved and all CIs are green after resolving merge conflicts.

@leofang leofang merged commit 5b49da6 into NVIDIA:main Apr 4, 2025
@leofang leofang deleted the fix_warning branch April 4, 2025 20:06
@github-actions

github-actions Bot commented Apr 4, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk left review comments

@kkraus14 kkraus14 kkraus14 left review comments

+1 more reviewer

@vzhurba01 vzhurba01 vzhurba01 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@leofang leofang

Labels

cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do

Projects

None yet

Milestone

cuda-python 12.9.0 & 11.8.7

Development

Successfully merging this pull request may close these issues.

4 participants

@leofang @rwgk @kkraus14 @vzhurba01