Add section Preparing kernel arguments#541
Conversation
vzhurba01
added
documentation
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
| )) | ||
| ``` | ||
|
|
||
| ### Using ctypes |
There was a problem hiding this comment.
It would be good to have an example of using Python buffer protocol (https://docs.python.org/3/c-api/buffer.html) compatible objects as well, though I'm not sure how we'd specify the struct type in that situation.
There was a problem hiding this comment.
The launch API supports Buffer Protocol objects, therefore we can pass the array object directly.
I tried to give this example by leveraging Numpy's array objects since they already have the protocol. Were you thinking about having an example of a custom user object that supports a Python buffer protocol as an example?
There was a problem hiding this comment.
I don't think we need to address this in this PR to be clear. Just mindful that we may want to make numpy an optional dependency in the future and if that's the case it would be nice to have an example of using buffer protocol without numpy (i.e. using the standard array library or something like that).
|
/ok to test |
|
/ok to test |
kkraus14
left a comment
kkraus14
left a comment
There was a problem hiding this comment.
Approving because only remaining comment is related to the linking to the example which we can handle in a follow up if desired
|
/ok to test |
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
Half way done, sorry for my slowness
Co-authored-by: Leo Fang <leo80042@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
Co-authored-by: Leo Fang <leo80042@gmail.com>
|
/ok to test |
leofang
left a comment
leofang
left a comment
There was a problem hiding this comment.
This is great improvement, thanks Vlad! I've completed my review.
|
/ok to test |
|
Thanks, Vlad and Keith/Ralf! |
|
4 participants
Close #127