Skip to content

Return None values when API errors#572

Merged
leofang merged 3 commits into
NVIDIA:mainfrom
vzhurba01:561-none-args
Apr 23, 2025
Merged

Return None values when API errors#572
leofang merged 3 commits into
NVIDIA:mainfrom
vzhurba01:561-none-args

Conversation

@vzhurba01

Copy link
Copy Markdown
Contributor

Description

closes #561

Failed API calls return None for non error code tuple elements

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vzhurba01 vzhurba01 added bug Something isn't working P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Apr 22, 2025
@vzhurba01 vzhurba01 added this to the cuda-python 12.9.0 & 11.8.7 milestone Apr 22, 2025
@vzhurba01 vzhurba01 self-assigned this Apr 22, 2025
@copy-pr-bot

copy-pr-bot Bot commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

/ok to test

@vzhurba01, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@vzhurba01

Copy link
Copy Markdown
Contributor Author

/ok to test c1f49d3

@github-actions

This comment has been minimized.

@leofang leofang requested review from leofang and rwgk April 22, 2025 22:57
leofang
leofang previously approved these changes Apr 22, 2025
@vzhurba01

Copy link
Copy Markdown
Contributor Author

/ok to test a33486d

@rwgk rwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vlad for going the extra mile!

@leofang leofang merged commit f0cb721 into NVIDIA:main Apr 23, 2025
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda.bindings Everything related to the cuda.bindings module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA]: Relevant exceptions for cuCheckpointProcessGetState

4 participants