Skip to content

Ensure fetch_ctk action can be used everywhere#600

Merged
leofang merged 33 commits into
NVIDIA:mainfrom
leofang:fix_win
May 4, 2025
Merged

Ensure fetch_ctk action can be used everywhere#600
leofang merged 33 commits into
NVIDIA:mainfrom
leofang:fix_win

Conversation

@leofang

@leofang leofang commented May 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

closes #599
closes #588

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang self-assigned this May 2, 2025
@copy-pr-bot

copy-pr-bot Bot commented May 2, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test ccb6967

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test 562b558

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test 270b681

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test 9e665db

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test 38830b2

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test 2bb32a9

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test dc633dc

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test cd69de3

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test 52adef2

@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test d5c7be2

1 similar comment
@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test d5c7be2

@leofang leofang closed this May 2, 2025
@leofang leofang reopened this May 2, 2025
@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test d5c7be2

1 similar comment
@leofang

leofang commented May 2, 2025

Copy link
Copy Markdown
Member Author

/ok to test d5c7be2

@leofang leofang mentioned this pull request May 3, 2025
Merged
@github-actions

This comment has been minimized.

Sign in to view
@leofang

leofang commented May 3, 2025

Copy link
Copy Markdown
Member Author

/ok to test 1b02e55

@leofang

leofang commented May 3, 2025

Copy link
Copy Markdown
Member Author

/ok to test 7a0e053

@leofang

leofang commented May 3, 2025

Copy link
Copy Markdown
Member Author

/ok to test 96ecae0

@leofang

leofang commented May 3, 2025

Copy link
Copy Markdown
Member Author

/ok to test a73564c

@leofang

leofang commented May 4, 2025

Copy link
Copy Markdown
Member Author

/ok to test 78d0113

@leofang

leofang commented May 4, 2025

Copy link
Copy Markdown
Member Author

/ok to test 390995a

@leofang

leofang commented May 4, 2025

Copy link
Copy Markdown
Member Author

/ok to test 65e19b2

@leofang

leofang commented May 4, 2025

Copy link
Copy Markdown
Member Author

/ok to test 6ade91b

@leofang leofang closed this May 4, 2025
auto-merge was automatically disabled May 4, 2025 02:55

Pull request was closed

@leofang

leofang commented May 4, 2025

Copy link
Copy Markdown
Member Author

/ok to test 6ade91b

@leofang leofang reopened this May 4, 2025
@leofang leofang enabled auto-merge (squash) May 4, 2025 03:27
@leofang

leofang commented May 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

OK @rwgk this PR is ready/safe to merge. I confirm fetch_ctk can handle all cache hit/miss paths properly on all supported GHA runners:

rwgk
rwgk approved these changes May 4, 2025
View reviewed changes
Comment thread .github/actions/fetch_ctk/action.yml
@leofang leofang merged commit 9579678 into NVIDIA:main May 4, 2025
@leofang leofang mentioned this pull request May 4, 2025
Closed
@leofang leofang deleted the fix_win branch May 4, 2025 03:51
@github-actions

github-actions Bot commented May 4, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang mentioned this pull request May 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

Assignees

@leofang leofang

Labels

CI/CD CI/CD infrastructure enhancement Any code-related improvements P0 High priority - Must do!

Projects

None yet

Milestone

cuda-python 12.9.0 & 11.8.7

Development

Successfully merging this pull request may close these issues.

CI: Enable our homegrown fetch_ctk action on Windows? CI: Windows local CTK installation at test time shows a warning

2 participants

@leofang @rwgk