Skip to content

Remove nvvm-related LD_LIBRARY_PATH, PATH manipulations in fetch_ctk action.#623

Merged
rwgk merged 1 commit into
NVIDIA:mainfrom
rwgk:remove_fetch_ctk_nvvm_related_path_manipulations
May 12, 2025
Merged

Remove nvvm-related LD_LIBRARY_PATH, PATH manipulations in fetch_ctk action.#623
rwgk merged 1 commit into
NVIDIA:mainfrom
rwgk:remove_fetch_ctk_nvvm_related_path_manipulations

Conversation

@rwgk

@rwgk rwgk commented May 10, 2025

Copy link
Copy Markdown
Contributor

Description

Currently we do not need any LD_LIBRARY_PATH or PATH manipulations for nvvm in any of our testing environments.

Possible explanation (I have NOT verified this): Either nvvm is installed via a Python wheel, or CUDA_HOME is set.

@copy-pr-bot

copy-pr-bot Bot commented May 10, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk rwgk self-assigned this May 10, 2025
@rwgk

rwgk commented May 10, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 414caf7

@github-actions

This comment has been minimized.

@rwgk rwgk changed the title Experiment: Remove nvvm-related LD_LIBRARY_PATH, PATH manipulations in fetch_ctk action. Remove nvvm-related LD_LIBRARY_PATH, PATH manipulations in fetch_ctk action. May 10, 2025
@rwgk rwgk marked this pull request as ready for review May 10, 2025 16:54
@copy-pr-bot

copy-pr-bot Bot commented May 10, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang leofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks Ralf!

@rwgk rwgk merged commit bbbb666 into NVIDIA:main May 12, 2025
53 checks passed
@rwgk rwgk deleted the remove_fetch_ctk_nvvm_related_path_manipulations branch May 12, 2025 15:52
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants