Skip to content

Add cufile bindings#684

Merged
leofang merged 41 commits into
NVIDIA:mainfrom
sourabgupta3:sg_cufile_bindings
Jul 18, 2025
Merged

Add cufile bindings#684
leofang merged 41 commits into
NVIDIA:mainfrom
sourabgupta3:sg_cufile_bindings

Conversation

@sourabgupta3

@sourabgupta3 sourabgupta3 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Description

closes #585

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang self-requested a review June 6, 2025 14:22
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Jun 6, 2025
@leofang leofang added P0 High priority - Must do! feature New feature or request cuda.bindings Everything related to the cuda.bindings module labels Jun 6, 2025
@leofang leofang changed the title Draft: Add cufile bindings(Not building currently) Draft: Add cufile bindings Jun 6, 2025
@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
Member

/ok to test 01990c0

@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
Member

@sourabgupta3 there are some CI works I'll need to address later, but please proceed to test it locally. It builds on Linux now.

@leofang

leofang commented Jun 18, 2025

Copy link
Copy Markdown
Member

/ok to test 5fed951

@leofang

leofang commented Jun 22, 2025

Copy link
Copy Markdown
Member

/ok to test 70837af

@leofang

leofang commented Jun 22, 2025

Copy link
Copy Markdown
Member

/ok to test 571f60b

@leofang

leofang commented Jun 22, 2025

Copy link
Copy Markdown
Member

/ok to test 77dbde4

@leofang

leofang commented Jun 22, 2025

Copy link
Copy Markdown
Member

/ok to test a3d62f2

@leofang

leofang commented Jun 23, 2025

Copy link
Copy Markdown
Member

/ok to test 5ff2f4e

@leofang

leofang commented Jul 3, 2025

Copy link
Copy Markdown
Member

/ok to test f469124

Comment thread cuda_bindings/cuda/bindings/cufile.pyx
@leofang

leofang commented Jul 3, 2025

Copy link
Copy Markdown
Member

/ok to test eaa8d6b

@leofang leofang changed the title Draft: Add cufile bindings Add cufile bindings Jul 3, 2025
leofang
leofang previously approved these changes Jul 3, 2025

@leofang leofang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is all green!

"numpy": ("https://numpy.org/doc/stable/", None),
"nvvm": ("https://docs.nvidia.com/cuda/libnvvm-api/", None),
"nvjitlink": ("https://docs.nvidia.com/cuda/nvjitlink/", None),
"cufile": ("https://docs.nvidia.com/gpudirect-storage/api-reference-guide/", None),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, this currently does not work, but it's not a blocker for merging.

@github-project-automation github-project-automation Bot moved this from In Progress to In Review in CCCL Jul 3, 2025
Comment thread cuda_bindings/cuda/bindings/cufile.pyx Outdated
@leofang

leofang commented Jul 18, 2025

Copy link
Copy Markdown
Member

/ok to test 01c8de9

leofang
leofang previously approved these changes Jul 18, 2025
@leofang leofang enabled auto-merge (squash) July 18, 2025 02:08
@leofang leofang disabled auto-merge July 18, 2025 02:24
Comment thread cuda_bindings/docs/source/module/cufile.rst Outdated
@leofang

leofang commented Jul 18, 2025

Copy link
Copy Markdown
Member

Since the CI was green and we only apply a doc change, let me admin-merge. Many thanks @sourabgupta3 for pushing this through the finish line with us!

@leofang leofang merged commit 248edca into NVIDIA:main Jul 18, 2025
1 check passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Jul 18, 2025
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.bindings Everything related to the cuda.bindings module feature New feature or request P0 High priority - Must do!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add cuFile bindings

2 participants