CAGRA ACE build: avoid rounding down graph degree during sub-index build#2325
Open
achirkin wants to merge 1 commit into
Open
CAGRA ACE build: avoid rounding down graph degree during sub-index build#2325achirkin wants to merge 1 commit into
achirkin wants to merge 1 commit into
Conversation
achirkin
added
bug
github-project-automation
Bot
moved this to Todo
in cuVS Library & Integrations Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
graph_degree / 2tofrom_hnswheuristics to getgraph_degreeback as a result unintentionally rounds down odd degrees, which corrupts subsequent copy operations during ACE index build.We workaround this issue by assigning the graph_degree explicitly on top of the heuristics.