#69 - Apply docs review feedback#109
Conversation
|
| Filename | Overview |
|---|---|
| docs/javascripts/tab-dropdowns.js | New JS file that injects hover dropdowns into MkDocs tab items; API Reference section is missing Python API Usage, leaving it unreachable from sidebar-hidden pages. |
| docs/index.html | Landing page updated with hamburger drawer for <1100 px viewports, nav dropdowns, and Raw Ethernet/stream_type terminology sweep; Python API also missing from the landing-page API Reference dropdown. |
| docs/api-reference/python.md | Only the broken anchor link was fixed; the "DPDK backend" text on line 133 was not updated to match the terminology sweep applied to cpp.md. |
| docs/concepts.md | Replaced Kernel Bypass / backend framing with stream_type + protocol sections; added GPUDirect mermaid diagram and rewrote Packets/Bursts/Segments/Flow/Memory Regions. |
| docs/getting-started.md | Relaxed NIC requirement to kernel-bypass/GPUDirect/RoCE paths only, bumped CUDA minimum to 12.2+, and inlined bare-metal apt dependency list. |
| docs/stylesheets/extra.css | Added content-width increase, nowrap on table code cells, tab-dropdown styles, and TOC item spacing; clean universal/slate scoping. |
| mkdocs.yml | Promoted Benchmarks to a top-level nav entry and added tab-dropdowns.js to extra_javascript. |
| AGENTS.md | Updated docs structure description to reflect stream_type/protocol vocabulary and the Benchmarks promotion. |
| docs/tutorials/configuration-walkthrough.md | Decision tree relabeled from backend to stream_type/protocol; RoCE reframed as third-party endpoint use case; hide: navigation added. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["API Reference tab (MkDocs)"] -->|"tab-dropdowns.js injects dropdown"| D1["API Guide\n(hide: navigation ✓)"]
A -->|"tab-dropdowns.js injects dropdown"| D2["Configuration YAML Reference\n(hide: navigation ✓)"]
A -->|"tab-dropdowns.js injects dropdown"| D3["C++ API Usage\n(hide: navigation ✓)"]
A -.->|"missing from dropdown"| D4["Python API Usage\n(sidebar still shown)"]
D1 -. "No sidebar, no dropdown link" .-> D4
D2 -. "No sidebar, no dropdown link" .-> D4
D3 -. "No sidebar, no dropdown link" .-> D4
style D4 stroke:#f00,stroke-width:2px
Reviews (3): Last reviewed commit: "#69 - Fix python.md link to RX Reorder C..." | Re-trigger Greptile
| ::-webkit-scrollbar { width:6px; height:6px; } | ||
| ::-webkit-scrollbar-track { background:var(--bg-dark); } | ||
| ::-webkit-scrollbar-thumb { background:#333; border-radius:99px; } | ||
| @media (max-width:1100px) { .nav-links { display:none; } } |
There was a problem hiding this comment.
Nav links hidden at 1100 px with no fallback navigation
The responsive breakpoint that hides .nav-links was raised from 640 px to 1100 px. On viewports between 640 px and 1100 px (tablets, small laptops), the entire top-nav strip — Concepts, Benchmarks, API Reference dropdown, Tutorials dropdown, News — disappears, but no hamburger menu or drawer is added. The .nav-actions buttons (GitHub / Docs) remain visible, but the only way to reach the new Concepts and Benchmarks pages from the landing page at that viewport is through the hero or tutorials scroll-list, which are not always visible above the fold.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Signed-off-by: Chloe Crozier <chloecrozier@gmail.com>
…oyment Signed-off-by: Chloe Crozier <chloecrozier@gmail.com>
…l deployment Signed-off-by: Chloe Crozier <chloecrozier@gmail.com>
The "RX Reorder Configs (DPDK v1)" heading in configuration.md was shortened to "RX Reorder Configs" in this PR, which renamed its generated anchor. Update the link from python.md (added in #104) so `mkdocs build --strict` passes. Signed-off-by: Chloe Crozier <chloecrozier@gmail.com>
Summary
Follow-up to the previous docs PR, addressing review feedback.
Content changes
stream_type+protocol. Stream Types section now has Raw / Socket (UDP, TCP, RoCE) / PCIe (future). Added a GPUDirect mermaid diagram, rewrote Packets/Bursts/Segments/Flow/Memory Regions per the wording suggestions.doca-ofedfor diagnostic utilities.flows:block in the Hardware Flow Steering example,sudo … --check alldiagnostic command, "Raw Ethernet" instead of "DPDK" in user-facing prose.host_pinned", peermem/dma-buf error details moved into a collapsed admonition.stream_type/protocol. RDMA reframed as for third-party RoCE endpoints (FPGA, instrument); two DAQIRI peers should use MPI / NCCL / UCX.DAQIRI_MGR=dpdk,daqiri_dpdk_*etc. kept).Layout / nav
--md-gridto 76rem,white-space: nowrapon table<code>cells).white-space: nowrapon links/buttons, collapse breakpoint).Test plan
mkdocs build --strict— passes locallyscripts/check_doc_refs.py— passes locally