-
Notifications
You must be signed in to change notification settings - Fork 4
#113 - Fix RDMA cross-host SEND timeout and shutdown deadlock #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chloecrozier
wants to merge
2
commits into
main
Choose a base branch
from
feature/spark-xhost-configs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # DGX Spark (GB10) cross-host RX-side config for daqiri_bench_raw_gpudirect. | ||
| # Companion to daqiri_bench_raw_tx_spark_xhost.yaml on the peer TX host. Both | ||
| # hosts must be configured per the DGX Spark profile in | ||
| # docs/tutorials/system_configuration.md, with the chosen p0 port cross-cabled | ||
| # host-to-host (no chassis QSFP loop). | ||
| # | ||
| # Spark substitutions baked in here: | ||
| # - rx_port BDF = 0000:01:00.0 (p0); change if your p0 sits elsewhere | ||
| # - kind: host_pinned (GB10 dma-buf path; nvidia-peermem N/A on Spark) | ||
| # - master_core: 8; cpu_core: 18 (isolated big-cluster X925 16-19) | ||
| # - flow match: udp_src/dst = 4096 -- same UDP tuple the TX side sends to | ||
| # | ||
| %YAML 1.2 | ||
| --- | ||
| daqiri: | ||
| cfg: | ||
| version: 1 | ||
| stream_type: "raw" | ||
| master_core: 8 | ||
| debug: false | ||
| log_level: "info" | ||
| loopback: "" | ||
|
|
||
| memory_regions: | ||
| - name: "Data_RX_GPU" | ||
| kind: "host_pinned" | ||
| affinity: 0 | ||
| num_bufs: 51200 | ||
| buf_size: 8064 | ||
|
|
||
| interfaces: | ||
| - name: "rx_port" | ||
| address: 0000:01:00.0 | ||
| rx: | ||
| flow_isolation: true | ||
| queues: | ||
| - name: "rq_q_0" | ||
| id: 0 | ||
| cpu_core: 18 | ||
| batch_size: 10240 | ||
| memory_regions: | ||
| - "Data_RX_GPU" | ||
| flows: | ||
| - name: "flow_0" | ||
| id: 0 | ||
| action: | ||
| type: queue | ||
| id: 0 | ||
| match: | ||
| udp_src: 4096 | ||
| udp_dst: 4096 | ||
|
|
||
| bench_rx: | ||
| interface_name: "rx_port" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # DGX Spark (GB10) cross-host TX-side config for daqiri_bench_raw_gpudirect. | ||
| # Companion to daqiri_bench_raw_rx_spark_xhost.yaml on the peer RX host. Both | ||
| # hosts must be configured per the DGX Spark profile in | ||
| # docs/tutorials/system_configuration.md, with the chosen p0 port cross-cabled | ||
| # host-to-host (no chassis QSFP loop). | ||
| # | ||
| # Spark substitutions baked in here: | ||
| # - tx_port BDF = 0000:01:00.0 (p0); change if your p0 sits elsewhere | ||
| # - kind: host_pinned (GB10 dma-buf path; nvidia-peermem N/A on Spark) | ||
| # - master_core: 8; cpu_core: 17 (isolated big-cluster X925 16-19) | ||
| # - eth_dst_addr is the *peer* RX port's MAC -- replace with your own: | ||
| # cat /sys/class/net/<peer rx ifname>/address # on the RX host | ||
| # - ip_src/ip_dst: arbitrary 1.1.1.1 -> 2.2.2.2 (kernel stack bypassed by | ||
| # the DPDK PMD; only the UDP src/dst ports below are matched by the RX | ||
| # flow rule in daqiri_bench_raw_rx_spark_xhost.yaml) | ||
| # | ||
| %YAML 1.2 | ||
| --- | ||
| daqiri: | ||
| cfg: | ||
| version: 1 | ||
| stream_type: "raw" | ||
| master_core: 8 | ||
| debug: false | ||
| log_level: "info" | ||
| loopback: "" | ||
|
|
||
| memory_regions: | ||
| - name: "Data_TX_GPU" | ||
| kind: "host_pinned" | ||
| affinity: 0 | ||
| num_bufs: 51200 | ||
| buf_size: 8064 | ||
|
|
||
| interfaces: | ||
| - name: "tx_port" | ||
| address: 0000:01:00.0 | ||
| tx: | ||
| queues: | ||
| - name: "tx_q_0" | ||
| id: 0 | ||
| batch_size: 10240 | ||
| cpu_core: 17 | ||
| memory_regions: | ||
| - "Data_TX_GPU" | ||
| offloads: | ||
| - "tx_eth_src" | ||
|
|
||
| bench_tx: | ||
| interface_name: "tx_port" | ||
| batch_size: 10240 | ||
| payload_size: 8000 | ||
| header_size: 64 | ||
| eth_dst_addr: <00:00:00:00:00:00> | ||
| ip_src_addr: 1.1.1.1 | ||
| ip_dst_addr: 2.2.2.2 | ||
| udp_src_port: 4096 | ||
| udp_dst_port: 4096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| # DGX Spark (GB10) cross-host config for daqiri_bench_rdma. | ||
| # Adapts the single-host daqiri_bench_rdma_tx_rx_spark.yaml to a two-host | ||
| # setup with each side's p0 cross-cabled to the peer's p0. Both hosts must | ||
| # be configured per the DGX Spark profile in | ||
| # docs/tutorials/system_configuration.md, except the IP assignment is | ||
| # split across hosts: put 1.1.1.1/24 on the client host's p0 and 2.2.2.2/24 | ||
| # on the server host's p0 (instead of both addresses on one machine). | ||
| # | ||
| # Run with --mode client on the TX host and --mode server on the RX host: | ||
| # server (RX): sudo ./daqiri_bench_rdma <this.yaml> --mode server --seconds 30 | ||
| # client (TX): sudo ./daqiri_bench_rdma <this.yaml> --mode client --seconds 30 | ||
| # | ||
| # This config is the regression test for the RDMA cross-host receive- | ||
| # provisioning bug fixed in issue #113. Before the fix, the server-side | ||
| # worker thread crashed on launch and no receives were ever posted. | ||
| # | ||
| # Spark substitutions baked in here: | ||
| # - IPs: 1.1.1.1 (client/TX p0) and 2.2.2.2 (server/RX p0) | ||
| # - cpu_core values from isolated big-cluster X925 16-19; master_core: 8 | ||
| # - kind: host_pinned (required upstream on GB10; peermem N/A, dma-buf used) | ||
| # | ||
| %YAML 1.2 | ||
| --- | ||
| daqiri: | ||
| cfg: | ||
| version: 1 | ||
| stream_type: "socket" | ||
| protocol: "roce" | ||
| master_core: 8 | ||
| debug: false | ||
| log_level: "info" | ||
|
|
||
| memory_regions: | ||
| - name: "DATA_RX_GPU_SERVER" | ||
| kind: "host_pinned" | ||
| affinity: 0 | ||
| num_bufs: 20 | ||
| buf_size: 9000000 | ||
| - name: "DATA_TX_GPU_SERVER" | ||
| kind: "host_pinned" | ||
| affinity: 0 | ||
| num_bufs: 20 | ||
| buf_size: 9000000 | ||
| - name: "DATA_TX_GPU_CLIENT" | ||
| kind: "host_pinned" | ||
| affinity: 0 | ||
| num_bufs: 20 | ||
| buf_size: 90000000 | ||
| - name: "DATA_RX_GPU_CLIENT" | ||
| kind: "host_pinned" | ||
| affinity: 0 | ||
| num_bufs: 20 | ||
| buf_size: 90000000 | ||
|
|
||
| interfaces: | ||
| - name: my_client | ||
| address: 1.1.1.1 | ||
| socket_config: | ||
| mode: client | ||
| remote_ip: 2.2.2.2 | ||
| remote_port: 4096 | ||
| roce_config: | ||
| transport_mode: RC | ||
| tx: | ||
| queues: | ||
| - name: "Client_TX_Queue" | ||
| id: 0 | ||
| batch_size: 1 | ||
| cpu_core: 17 | ||
| rx: | ||
| queues: | ||
| - name: "Client_RX_Queue" | ||
| id: 0 | ||
| cpu_core: 18 | ||
| batch_size: 1 | ||
| - name: my_server | ||
| address: 2.2.2.2 | ||
| socket_config: | ||
| mode: server | ||
| local_ip: 2.2.2.2 | ||
| local_port: 4096 | ||
| roce_config: | ||
| transport_mode: RC | ||
| rx: | ||
| queues: | ||
| - name: "Server_RX_Queue" | ||
| id: 0 | ||
| cpu_core: 19 | ||
| batch_size: 1 | ||
| tx: | ||
| queues: | ||
| - name: "Server_TX_Queue" | ||
| id: 0 | ||
| cpu_core: 16 | ||
| batch_size: 1 | ||
|
|
||
| rdma_bench_server: | ||
| server_address: 2.2.2.2 | ||
| server_port: 4096 | ||
| message_size: 8000000 | ||
| send: true | ||
| receive: true | ||
| server: true | ||
|
|
||
| rdma_bench_client: | ||
| message_size: 8000000 | ||
| client_address: 1.1.1.1 | ||
| server_address: 2.2.2.2 | ||
| server_port: 4096 | ||
| receive: true | ||
| send: true | ||
| server: false | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.