#119 - Add uninstall script for the CMake install and container image#120
Conversation
Signed-off-by: Chloe Crozier <chloecrozier@gmail.com>
Signed-off-by: Chloe Crozier <chloecrozier@gmail.com>
|
| Filename | Overview |
|---|---|
| scripts/cleanup.sh | New 432-line cleanup script: manifest-driven and scan-driven cmake removal, container image removal, ldconfig refresh after removal (addresses prior review feedback), confirmation/dry-run/assume-yes modes, and verify_cmake/verify_container post-removal checks. Logic is sound and defensive. |
| docs/tutorials/bare-metal-cmake-build.md | Adds a Cleanup section with usage instructions and a prose description of verification; the description lists ls /opt/daqiri as the first verification check but the script does a targeted artifact scan, not a bare directory listing. |
| docs/getting-started.md | Adds a Cleanup section with example invocations for container, cmake, and all targets, plus a cross-link to the bare-metal tutorial. Content is accurate. |
Reviews (6): Last reviewed commit: "#119 - Harden cleanup script reruns" | Re-trigger Greptile
|
Addressed and applied greptile's comments. |
|
I tested uninstall.sh container on my IGX. The dry run and full unisntall behavior all looked good! Maybe @dleshchev can test the cmake uninstall on his system before we merge this in. One minor semantic thing: I think we discussed yesterday calling this script something like "cleanup.sh" instead of "uninstall.sh". |
Signed-off-by: Chloe Crozier <chloecrozier@gmail.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Chloe Crozier <chloecrozier@gmail.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Chloe Crozier <chloecrozier@gmail.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…install script Signed-off-by: Chloe Crozier <chloecrozier@gmail.com>
Rename scripts/uninstall.sh to scripts/cleanup.sh and follow through on
all in-repo references: the two info() banners in the script
("Verifying CMake/container cleanup:"), the Cleanup section heading and
commands in docs/getting-started.md, and Step 7 in
docs/tutorials/bare-metal-cmake-build.md (including the cross-link
anchor #step-7-cleanup). The script's usage line picks up the new
basename automatically. No behavior changes.
Signed-off-by: Chloe Crozier <chloecrozier@gmail.com>
Signed-off-by: Chloe Crozier <chloecrozier@gmail.com>
Signed-off-by: Denis Leshchev <dleshchev@nvidia.com>
f451e93 to
eabf40e
Compare
Summary
Add
scripts/cleanup.shto remove DAQIRI's CMake install or container image without touching build prerequisites (DPDK, DOCA libraries, CUDA, hugepages, NIC drivers). Targets arecmake,container, andall, with--dry-run,--yes, and built-in verification. The cmake target is manifest-driven with a name-scoped fallback scan; container verification surfaces (without auto-removing) dangling images and exited containers from interrupted builds. Short usage notes are added todocs/tutorials/bare-metal-cmake-build.mdanddocs/getting-started.md.Test plan
build/install_manifest.txt.OKfor every check.To Do: