Skip to content

feat: mark persistence mode diable as warning level#225

Merged
ambermingxin merged 1 commit into
mainfrom
feat/persistence-mode-warn
Jun 25, 2026
Merged

feat: mark persistence mode diable as warning level#225
ambermingxin merged 1 commit into
mainfrom
feat/persistence-mode-warn

Conversation

@ambermingxin

@ambermingxin ambermingxin commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Summary by CodeRabbit

  • Bug Fixes
    • Health status for NVIDIA persistence mode is now reported as Degraded when persistence mode is disabled, instead of Unhealthy.
    • Error-related checks continue to report Unhealthy for actual query failures, keeping critical issues distinct from configuration issues.
    • Updated expected health results in related checks to match the new status behavior.

Signed-off-by: Amber Xue <ambermingxin@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 19ab0708-bda1-45ff-8190-a8132c6fa7a6

📥 Commits

Reviewing files that changed from the base of the PR and between 67cf5cf and f4106f9.

📒 Files selected for processing (2)
  • third_party/fleet-intelligence-sdk/components/accelerator/nvidia/persistence-mode/component.go
  • third_party/fleet-intelligence-sdk/components/accelerator/nvidia/persistence-mode/component_test.go

📝 Walkthrough

Walkthrough

Persistence-mode checks now classify disabled persistence mode as Degraded instead of Unhealthy, while keeping NVML query and GPU error paths Unhealthy. The corresponding tests were updated to match the new health state.

Changes

Persistence-mode health handling

Layer / File(s) Summary
Health classification update
third_party/fleet-intelligence-sdk/components/accelerator/nvidia/persistence-mode/component.go
The check path keeps NVML and GPU error conditions Unhealthy, and changes disabled persistence mode to Degraded with explanatory comments.
Expectation updates
third_party/fleet-intelligence-sdk/components/accelerator/nvidia/persistence-mode/component_test.go
The persistence-mode tests now expect Degraded for disabled persistence mode cases in single-device and table-driven scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hopped through the GPU lane,
Degraded now when settings remain.
Unhealthy stays for errors hard,
The tests all nod in the yard.
Thump thump — the checks align again!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: persistence mode disabled is treated as a warning/degraded state instead of unhealthy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/persistence-mode-warn

Comment @coderabbitai help to get the list of available commands.

@ambermingxin ambermingxin requested a review from jingxiang-z June 25, 2026 23:30
@ambermingxin ambermingxin merged commit ca5447e into main Jun 25, 2026
9 checks passed
@ambermingxin ambermingxin deleted the feat/persistence-mode-warn branch June 25, 2026 23:33
jingxiang-z pushed a commit that referenced this pull request Jun 27, 2026
Signed-off-by: Amber Xue <ambermingxin@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants