dpf: Update doc to include role for bluefieldsoftwares#3438
Open
abvarshney-nv wants to merge 1 commit into
Open
dpf: Update doc to include role for bluefieldsoftwares#3438abvarshney-nv wants to merge 1 commit into
abvarshney-nv wants to merge 1 commit into
Conversation
Contributor
Summary by CodeRabbit
WalkthroughThe DPF manual updates the cluster-wide ChangesDPF RBAC Updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔍 Container Scan SummaryNo Grype artifacts were found to aggregate. |
|
🌿 Preview your docs: https://nvidia-preview-pull-request-3438.docs.buildwithfern.com/infra-controller |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/manuals/dpf.md`:
- Line 366: Update the RBAC configuration containing the resources list to
provide namespace-wide access for the namespaced svc.dpu.nvidia.com resources:
replace the namespace-scoped RoleBinding approach with a ClusterRole and
ClusterRoleBinding, or add equivalent RoleBindings in every target per-DPU
namespace. Ensure access is not limited to dpf-operator-system.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 7357f22d-72a8-4fe8-b3a2-b06ca3c2a8cd
📒 Files selected for processing (1)
docs/manuals/dpf.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update doc to include role for bluefieldsoftwares
Related issues
Type of Change
Breaking Changes
Testing
Additional Notes