Skip to content

dpf: Update doc to include role for bluefieldsoftwares#3438

Open
abvarshney-nv wants to merge 1 commit into
NVIDIA:mainfrom
abvarshney-nv:dpf_doc_update
Open

dpf: Update doc to include role for bluefieldsoftwares#3438
abvarshney-nv wants to merge 1 commit into
NVIDIA:mainfrom
abvarshney-nv:dpf_doc_update

Conversation

@abvarshney-nv

@abvarshney-nv abvarshney-nv commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Update doc to include role for bluefieldsoftwares

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Summary by CodeRabbit

  • Bug Fixes
    • Updated access permissions for DPU service resources, improving compatibility and reliability for deployments that use service interfaces, templates, configurations, network attachments, and BlueField software resources.

Walkthrough

The DPF manual updates the cluster-wide carbide-api RBAC Role to include five additional svc.dpu.nvidia.com resources.

Changes

DPF RBAC Updates

Layer / File(s) Summary
Expand DPU resource permissions
docs/manuals/dpf.md
The documented Role now includes dpuserviceinterfaces, dpuservicetemplates, dpuserviceconfigurations, dpuservicenads, and bluefieldsoftwares.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the documentation update for the bluefieldsoftwares role.
Description check ✅ Passed The description matches the PR objective and accurately describes the doc-only change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔍 Container Scan Summary

No Grype artifacts were found to aggregate.

@github-actions

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/manuals/dpf.md`:
- Line 366: Update the RBAC configuration containing the resources list to
provide namespace-wide access for the namespaced svc.dpu.nvidia.com resources:
replace the namespace-scoped RoleBinding approach with a ClusterRole and
ClusterRoleBinding, or add equivalent RoleBindings in every target per-DPU
namespace. Ensure access is not limited to dpf-operator-system.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7357f22d-72a8-4fe8-b3a2-b06ca3c2a8cd

📥 Commits

Reviewing files that changed from the base of the PR and between ae62c4b and 919859c.

📒 Files selected for processing (1)
  • docs/manuals/dpf.md

Comment thread docs/manuals/dpf.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant