fix: avoid panic on empty cmdline in config-manager findPidToSignal#1735
Open
SAY-5 wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: avoid panic on empty cmdline in config-manager findPidToSignal#1735SAY-5 wants to merge 1 commit intoNVIDIA:mainfrom
SAY-5 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
procfs.Proc.CmdLine() returns an empty slice for kernel threads and processes that exit between AllProcs() and CmdLine(). Indexing cmdline[0] without a length check panics with 'index out of range [0] with length 0', crashing the config-manager into CrashLoopBackOff. Skip such processes and continue scanning so the manager can either locate the target PID or return the existing 'no process found' error. Fixes NVIDIA#1726 Signed-off-by: SAY-5 <saiasish.cnp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1726.
procfs.Proc.CmdLine()returns an empty slice for kernel threads and processes that exit betweenAllProcs()andCmdLine(). The current code infindPidToSignalindexescmdline[0]without a length check, which panics withindex out of range [0] with length 0and crashes the config-manager intoCrashLoopBackOffwhen dynamically switching to a config such asmps-10x.Skip processes with an empty cmdline and continue the scan so the manager can either locate the target PID or fall through to the existing
no process founderror.