Fix data_process scripts: import, progressbar init and bounds#75
Open
thomasarmstrong98 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fix data_process scripts: import, progressbar init and bounds#75thomasarmstrong98 wants to merge 1 commit intoNVIDIA:mainfrom
thomasarmstrong98 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
- Use absolute import for wb2_helpers in convert_wb2_to_makani_input.py since the documented invocation is direct script execution (python script.py), not module execution (python -m), which breaks relative imports. - Call progressbar.start() before update() as required by progressbar2 API. - Clamp progress count to maxval to prevent ValueError in distributed settings where aggregated count can momentarily exceed the total.
Collaborator
|
Hello Thomas, thanks for the fix. The imports here are a bit inconsistent I agree, since data_process does not belong to the package. Instead of your solution, can we do the same thing we applied here: I had some situations where one or the either approach breaks, but the one above is the most robust. If you have a more elegant solution, I am happy to look into that too. Best regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use absolute import for wb2_helpers in convert_wb2_to_makani_input.py since the documented invocation is direct script execution (python script.py), not module execution (python -m), which breaks relative imports.
Call progressbar.start() before update() as required by progressbar2 API.
Clamp progress count to maxval to prevent ValueError in distributed settings where aggregated count can momentarily exceed the total.