Skip to content

PyPi package name ast_canopy -> ast-canopy#316

Draft
cryos wants to merge 1 commit intoNVIDIA:mainfrom
cryos:build-wheel-metadata
Draft

PyPi package name ast_canopy -> ast-canopy#316
cryos wants to merge 1 commit intoNVIDIA:mainfrom
cryos:build-wheel-metadata

Conversation

@cryos
Copy link
Copy Markdown
Collaborator

@cryos cryos commented Apr 3, 2026

Harmonize with the conda approach, in PyPi ast_canopy and ast-canopy are normalized and the same. We agreed to do this to keep package names in sync. From the external perspective both forms will still resolve to this package.

Closes #312.

Summary by CodeRabbit

Chores

  • Updated project distribution naming convention from underscore to hyphenated format (ast_canopyast-canopy).
  • Updated dependency references to reflect the new distribution name across packages.

Harmonize with the conda approach, in PyPi ast_canopy and ast-canopy are
normalized and the same. We agreed to do this to keep package names in
sync. From the external perspective both forms will still resolve to
this package.
@cryos cryos added the Build Build and packaging related work label Apr 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

📝 Walkthrough

Walkthrough

Updated package distribution name from underscore format (ast_canopy) to hyphen format (ast-canopy) in both the source package definition and its downstream dependency reference across two configuration files.

Changes

Cohort / File(s) Summary
Package naming standardization
ast_canopy/pyproject.toml, numbast/pyproject.toml
Updated distribution name from ast_canopy to ast-canopy in project metadata and updated corresponding dependency specifier to match the new naming convention.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A hop and a dash, from snake to hyphen,
Names aligned in perfect rhyme, then
Dependencies dance in sync once more,
Packages polished, conventions restored! 🌱✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the PyPI package name from ast_canopy to ast-canopy across both pyproject.toml files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Doc Preview CI
🚀 View pre-built docs at
https://NVIDIA.github.io/numbast/pr-preview/pr-316/

Preview will be ready when GitHub Pages deployment finishes.

@cryos cryos marked this pull request as ready for review April 3, 2026 15:40
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ast_canopy/pyproject.toml`:
- Line 9: The conda recipes still use the underscored package name "ast_canopy"
while pyproject changed the PyPI name to "ast-canopy"; update the conda metadata
to match by replacing the package name declaration "ast_canopy" in the package
meta.yaml with "ast-canopy" and update the dependency entry in the numbast
recipe that lists "ast_canopy" to "ast-canopy" so both the package declaration
and the dependency use the hyphenated name.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 57f64663-c862-40a3-9d02-66e2ebac4e36

📥 Commits

Reviewing files that changed from the base of the PR and between fd5e8ad and aacab36.

📒 Files selected for processing (2)
  • ast_canopy/pyproject.toml
  • numbast/pyproject.toml

Comment thread ast_canopy/pyproject.toml

[project]
name = "ast_canopy"
name = "ast-canopy"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify naming consistency across packaging metadata files.
set -euo pipefail

echo "== pyproject references =="
rg -n --type toml 'ast[-_]canopy' ast_canopy/pyproject.toml numbast/pyproject.toml

echo
echo "== conda recipe references =="
fd -i 'meta.yaml' conda/recipes --exec rg -n 'ast[-_]canopy' {}

Repository: NVIDIA/numbast

Length of output: 423


🏁 Script executed:

#!/bin/bash
# Identify which meta.yaml files have ast_canopy references with context
fd -i 'meta.yaml' conda/recipes --exec sh -c '
  echo "=== {} ==="
  rg -n -B2 -A2 "ast_canopy" "$1"
' _ {}

Repository: NVIDIA/numbast

Length of output: 530


Update conda package name to match PyPI distribution naming.

Line 9 changes the PyPI distribution name to ast-canopy (hyphen), but conda metadata still uses ast_canopy (underscore) in two locations:

  • conda/recipes/ast_canopy/meta.yaml line 10: package name declaration
  • conda/recipes/numbast/meta.yaml line 51: dependency specification
Required follow-up patch
diff --git a/conda/recipes/ast_canopy/meta.yaml b/conda/recipes/ast_canopy/meta.yaml
@@
 package:
-  name: ast_canopy
+  name: ast-canopy
   version: {{ PROJECT_VERSION }}

diff --git a/conda/recipes/numbast/meta.yaml b/conda/recipes/numbast/meta.yaml
@@
 run:
-    - ast_canopy >={{ PROJECT_VERSION }}
+    - ast-canopy >={{ PROJECT_VERSION }}
     - cuda-nvrtc
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ast_canopy/pyproject.toml` at line 9, The conda recipes still use the
underscored package name "ast_canopy" while pyproject changed the PyPI name to
"ast-canopy"; update the conda metadata to match by replacing the package name
declaration "ast_canopy" in the package meta.yaml with "ast-canopy" and update
the dependency entry in the numbast recipe that lists "ast_canopy" to
"ast-canopy" so both the package declaration and the dependency use the
hyphenated name.

@cryos cryos marked this pull request as draft April 3, 2026 17:30
@cryos
Copy link
Copy Markdown
Collaborator Author

cryos commented Apr 3, 2026

Just putting this on hold, just appreciating that conda does not normalize, and historically it was ast_canopy in conda so perhaps sticking with the underscore and changing the conda-forge recipe would be preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Build and packaging related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update PyPi package metadata

1 participant