PyPi package name ast_canopy -> ast-canopy#316
Conversation
Harmonize with the conda approach, in PyPi ast_canopy and ast-canopy are normalized and the same. We agreed to do this to keep package names in sync. From the external perspective both forms will still resolve to this package.
📝 WalkthroughWalkthroughUpdated package distribution name from underscore format ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ast_canopy/pyproject.toml`:
- Line 9: The conda recipes still use the underscored package name "ast_canopy"
while pyproject changed the PyPI name to "ast-canopy"; update the conda metadata
to match by replacing the package name declaration "ast_canopy" in the package
meta.yaml with "ast-canopy" and update the dependency entry in the numbast
recipe that lists "ast_canopy" to "ast-canopy" so both the package declaration
and the dependency use the hyphenated name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 57f64663-c862-40a3-9d02-66e2ebac4e36
📒 Files selected for processing (2)
ast_canopy/pyproject.tomlnumbast/pyproject.toml
|
|
||
| [project] | ||
| name = "ast_canopy" | ||
| name = "ast-canopy" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify naming consistency across packaging metadata files.
set -euo pipefail
echo "== pyproject references =="
rg -n --type toml 'ast[-_]canopy' ast_canopy/pyproject.toml numbast/pyproject.toml
echo
echo "== conda recipe references =="
fd -i 'meta.yaml' conda/recipes --exec rg -n 'ast[-_]canopy' {}Repository: NVIDIA/numbast
Length of output: 423
🏁 Script executed:
#!/bin/bash
# Identify which meta.yaml files have ast_canopy references with context
fd -i 'meta.yaml' conda/recipes --exec sh -c '
echo "=== {} ==="
rg -n -B2 -A2 "ast_canopy" "$1"
' _ {}Repository: NVIDIA/numbast
Length of output: 530
Update conda package name to match PyPI distribution naming.
Line 9 changes the PyPI distribution name to ast-canopy (hyphen), but conda metadata still uses ast_canopy (underscore) in two locations:
conda/recipes/ast_canopy/meta.yamlline 10: package name declarationconda/recipes/numbast/meta.yamlline 51: dependency specification
Required follow-up patch
diff --git a/conda/recipes/ast_canopy/meta.yaml b/conda/recipes/ast_canopy/meta.yaml
@@
package:
- name: ast_canopy
+ name: ast-canopy
version: {{ PROJECT_VERSION }}
diff --git a/conda/recipes/numbast/meta.yaml b/conda/recipes/numbast/meta.yaml
@@
run:
- - ast_canopy >={{ PROJECT_VERSION }}
+ - ast-canopy >={{ PROJECT_VERSION }}
- cuda-nvrtc🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@ast_canopy/pyproject.toml` at line 9, The conda recipes still use the
underscored package name "ast_canopy" while pyproject changed the PyPI name to
"ast-canopy"; update the conda metadata to match by replacing the package name
declaration "ast_canopy" in the package meta.yaml with "ast-canopy" and update
the dependency entry in the numbast recipe that lists "ast_canopy" to
"ast-canopy" so both the package declaration and the dependency use the
hyphenated name.
|
Just putting this on hold, just appreciating that conda does not normalize, and historically it was |
Harmonize with the conda approach, in PyPi ast_canopy and ast-canopy are normalized and the same. We agreed to do this to keep package names in sync. From the external perspective both forms will still resolve to this package.
Closes #312.
Summary by CodeRabbit
Chores
ast_canopy→ast-canopy).