Allow users to control iteration via the concept of iteration spaces. by robertmaynard · Pull Request #80 · NVIDIA/nvbench

robertmaynard · 2022-02-25T20:10:16Z

Changes in the work include:

Internally use linear_space for iterating
Simplify type and value iteration in state_iterator::build_axis_configs
Store the iteration space in axes_metadata
Expose zip and user spaces to user
Add tests for linear, zip, and user
Add examples for zip and user

Fixes #68

Changes in the work include: - [x] Internally use linear_space for iterating - [x] Simplify type and value iteration in `state_iterator::build_axis_configs` - [x] Store the iteration space in `axes_metadata` - [x] Expose `tie` and `user` spaces to user - [x] Add tests for `linear`, `tie`, and `user` - [x] Add examples for `tie` and `user`

docs/benchmarks.md

examples/custom_iteration_spaces.cu

jrhemstad

re: naming, I'd stick with zip as opposed to tie.

I think "zip" is more intuitive and descriptive based on the precedence of things like thrust::zip_iterator and std::ranges::zip_view.

jrhemstad · 2022-02-28T16:31:43Z

nvbench/axis_iteration_space.cuh

+  virtual std::unique_ptr<axis_space_base> do_clone() const         = 0;
+  virtual detail::axis_space_iterator do_iter(axes_info info) const = 0;
+  virtual std::size_t do_size(const axes_info &info) const          = 0;
+  virtual std::size_t do_valid_count(const axes_info &info) const   = 0;


It'd be nice to get some docs on the concept of a "axis space" as well as the semantics of these functions.

Agreed, same for the linear_axis_space and other subclasses below.

I have added more documentation

docs/benchmarks.md

alliepiper

Did an initial round of review, but didn't finish -- sharing my comments so far. Will give this a closer look later.

In the meantime, can you go through this and add documentation for the new interfaces?

Having a high-level overview of how these pieces fit together would also be helpful, maybe include that in the class docs for nvbench::detail::axes_iterator.

docs/benchmarks.md

nvbench/benchmark_base.cuh

docs/benchmarks.md

nvbench/axis_iteration_space.cuh

nvbench/axis_iteration_space.cxx

nvbench/axis_iteration_space.cuh

nvbench/axis_iteration_space.cxx

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

bdice · 2024-08-07T21:23:05Z

Can we revive this PR? Are there blockers?

copy-pr-bot · 2025-05-01T16:41:23Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

alliepiper · 2025-05-01T16:56:31Z

/ok to test 4defa02

alliepiper · 2025-05-01T17:28:27Z

/ok to test 4bd5690

alliepiper · 2025-05-02T19:01:07Z

/ok to test

copy-pr-bot · 2025-05-02T19:01:10Z

/ok to test

@alliepiper, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

alliepiper · 2025-05-02T19:01:32Z

/ok to test a2bf266

alliepiper · 2025-05-02T20:55:48Z

/ok to test c8909c7

alliepiper · 2025-05-07T20:44:19Z

I see a way to simplify this. Marking as draft as I work on the implementation.

jrhemstad reviewed Feb 26, 2022

View reviewed changes

docs/benchmarks.md Show resolved Hide resolved

jrhemstad reviewed Feb 26, 2022

View reviewed changes

examples/custom_iteration_spaces.cu Outdated Show resolved Hide resolved

jrhemstad reviewed Feb 28, 2022

View reviewed changes

docs/benchmarks.md Outdated Show resolved Hide resolved

Rename tie_axes to zip_axes

a25f578

robertmaynard force-pushed the fea/axes_iteration_space branch from 182f1da to a25f578 Compare February 28, 2022 19:23

implement easier API to add axis and zip/user iteration at the same time

c3c86e1

robertmaynard force-pushed the fea/axes_iteration_space branch from 0a2130f to c3c86e1 Compare February 28, 2022 21:44

Show zip versus linear iteration

91c8f43

jrhemstad reviewed Mar 1, 2022

View reviewed changes

docs/benchmarks.md Outdated Show resolved Hide resolved

PointKernel mentioned this pull request Mar 22, 2022

Erase Functionality for static_map NVIDIA/cuCollections#142

Merged

alliepiper reviewed Apr 11, 2022

View reviewed changes

robertmaynard and others added 11 commits April 12, 2022 09:46

Update docs/benchmarks.md

f4570d4

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

Update docs/benchmarks.md

f791475

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

Update nvbench/axis_iteration_space.cxx

f50a6dd

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

Update nvbench/axis_iteration_space.cuh

796f7f7

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

Update nvbench/axis_iteration_space.cxx

edba477

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

Update examples/custom_iteration_spaces.cu

9337ba9

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

Update examples/custom_iteration_spaces.cu

a02d648

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

Update examples/custom_iteration_spaces.cu

e80392e

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

Update examples/custom_iteration_spaces.cu

4c964d2

Co-authored-by: Allison Vacanti <alliepiper16@gmail.com>

More cleanup

26467f3

More cleanup

5b000e8

robertmaynard force-pushed the fea/axes_iteration_space branch 3 times, most recently from 5dc6c83 to d8d80e4 Compare April 12, 2022 16:22

Refactor names

ba8356f

robertmaynard force-pushed the fea/axes_iteration_space branch from d8d80e4 to ba8356f Compare April 12, 2022 16:35

robertmaynard force-pushed the fea/axes_iteration_space branch from 282754b to 5708e6c Compare August 31, 2022 15:08

robertmaynard added 3 commits August 31, 2022 11:13

update axis_space_iterator to use same method names as state_iterator

3ad3d65

remove need for output_indices

c2bfc99

Simplified user iterators

910b5cc

PointKernel mentioned this pull request Aug 7, 2024

Add keep option to distinct nvbench rapidsai/cudf#16497

Merged

3 tasks

alliepiper added 5 commits May 1, 2025 15:14

Merge remote-tracking branch 'origin/main' into fea/axes_iteration_space

50e764a

Merge remote-tracking branch 'origin/main' into fea/axes_iteration_space

5016bec

Reduce runtime of gaussian iteration example.

62cbdc5

Update fmt usage for new version.

edefcd0

Update new test to support device-init changes.

250d755

Precommit reformatting.

4defa02

Fix warnings on clang.

4bd5690

alliepiper added 6 commits May 1, 2025 17:40

Update docs, whitespace.

cca9308

Merge remote-tracking branch 'origin/main' into fea/axes_iteration_space

c9d92eb

Updated some docs.

498c73d

Rename header to match class name

0fae005

Docs update.

d7989dd

Rename some space -> spaces for clarity.

a2bf266

alliepiper force-pushed the fea/axes_iteration_space branch from c820ec0 to a2bf266 Compare May 2, 2025 18:53

Refactoring / renaming.

c8909c7

alliepiper marked this pull request as draft May 7, 2025 20:43

Conversation

robertmaynard commented Feb 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jrhemstad left a comment

Choose a reason for hiding this comment

Uh oh!

jrhemstad Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

alliepiper Apr 11, 2022

Choose a reason for hiding this comment

Uh oh!

robertmaynard May 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alliepiper left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bdice commented Aug 7, 2024

Uh oh!

copy-pr-bot bot commented May 1, 2025

Uh oh!

alliepiper commented May 1, 2025

Uh oh!

alliepiper commented May 1, 2025

Uh oh!

alliepiper commented May 2, 2025

Uh oh!

copy-pr-bot bot commented May 2, 2025

Uh oh!

alliepiper commented May 2, 2025

Uh oh!

alliepiper commented May 2, 2025

Uh oh!

alliepiper commented May 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

robertmaynard commented Feb 25, 2022 •

edited

Loading

alliepiper left a comment •

edited

Loading