Skip to content

feat(helm-reval): expose GET /info endpoint#275

Draft
priyaselvaganesan wants to merge 7 commits into
mainfrom
feat/version-endpoint-helm-reval
Draft

feat(helm-reval): expose GET /info endpoint#275
priyaselvaganesan wants to merge 7 commits into
mainfrom
feat/version-endpoint-helm-reval

Conversation

@priyaselvaganesan

@priyaselvaganesan priyaselvaganesan commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

TL;DR

Adds GET /info to the helm-reval management server (port 8082, alongside /healthz and /log_level). Returns service name, semver, and commit SHA injected at build time via Bazel x_defs.

Additional Details

nvcfversion.Handler() from go-lib serves the response. Service, version, and commit are resolved from the Service, Version, and GitHash package vars set via x_defs in BUILD.bazel when building with --stamp.

This PR is blocked on go-lib PR #270. Once that merges, go.mod will be updated to the published version that includes Handler() and CI will go green.

Changes:

  • cmd/reval/cli/server.go: registers nvcfversion.Handler() at GET /info in serveManagementRoutes
  • cmd/reval/cli/BUILD.bazel: adds go-lib pkg/version to deps
  • cmd/reval-service/BUILD.bazel: adds Service x_def ("nvcf-helm-reval-api") alongside the existing Version and GitHash x_defs

For the Reviewer

For QA

Tested locally on ncp-local k3d cluster:

kubectl port-forward deployment/reval 8082:8082 -n nvcf
curl http://localhost:8082/info
{"service":"nvcf-helm-reval-api","version":"...","commit":"2c495cc5-dirty"}

Issues

Relates to #315

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@priyaselvaganesan
feat(go-lib/version): add Handler and HandlerFor http.Handler
f779787 
Adds a shared HTTP handler to go-lib/pkg/version that serves build
metadata as JSON at GET /version. Version and commit are injected at
link time via Bazel x_defs (STABLE_VERSION, STABLE_GIT_COMMIT) when
built with --stamp. Falls back to Go runtime build info for commit
when GitHash is not injected, so local go build still returns a real
commit SHA.

Response schema: {"version": "v1.2.3", "commit": "abc1234"}

Refs: NVCF-10975
@priyaselvaganesan
feat(helm-reval): expose GET /version endpoint
a799e06 
Adds a GET /version handler to the management server (port 8082,
alongside /healthz and /log_level). Returns service semver and commit
SHA injected at build time via Bazel x_defs.

Blocked on go-lib PR #270 merging. Once that lands, go.mod will be
updated to the published version and the inline handler replaced with
nvcfversion.Handler().

Refs: NVCF-10975
@coderabbitai

coderabbitai Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4d069cac-39e0-4af8-b854-425b935b53ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/version-endpoint-helm-reval

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🛡️ CodeQL Analysis

🚨 Found 2 issue(s)

Severity Breakdown:

  • 🔴 Errors: 0
  • 🟡 Warnings: 0
  • 🔵 Notes: 0
📋 Top Issues

🔗 View full details in Security tab

🕐 Last updated: 2026-07-20 21:20:10 UTC | Commit: a799e06

@kristinapathak

kristinapathak commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Please provide a Github issue instead of an internal JIRA.

@priyaselvaganesan

priyaselvaganesan commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Please provide a Github issue instead of an internal JIRA.

Done — created issue #315 and updated the Issues section.

@priyaselvaganesan

priyaselvaganesan commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Bazel CI failure is expected. nvcfversion.Handler() is defined in go-lib PR #270 which has not merged yet. Once that lands, go.mod will be updated to the new go-lib version and this will go green.

@priyaselvaganesan
feat(go-lib/version): add Service field, rename endpoint to GET /info
d7bc3d2 
Adds Service string var injected via x_defs so each service identifies
itself in the response. Renames from GET /version to GET /info following
reviewer feedback that /info is more extensible for future fields.

Response schema: {"service":"nvcf-my-service","version":"v1.2.3","commit":"abc1234"}

Refs: NVCF-10975
@priyaselvaganesan
feat(helm-reval): expose GET /info endpoint with service metadata
d6e6857 
Registers nvcfversion.Handler() at GET /info on the management server
(port 8082). Returns service name, semver, and commit SHA injected at
build time via Bazel x_defs.

Blocked on go-lib PR #270 merging. Once that lands, go.mod will be
updated to the published version that includes Handler().

Refs: NVCF-10975
@priyaselvaganesan priyaselvaganesan changed the title feat(helm-reval): expose GET /version endpoint feat(helm-reval): expose GET /info endpoint Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@priyaselvaganesan @kristinapathak