Skip to content

fix(self-managed): consume reconnect-enabled SIS chart #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbaum1994 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(self-managed): consume reconnect-enabled SIS chart #392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5181641
fix(self-managed): consume reconnect-enabled SIS chart
sbaum1994 Jul 23, 2026
27354d4
Merge branch 'main' into sbaum1994/fix/sis-chart-1.18.7
sbaum1994 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ releases:
- template: service

- name: sis
version: 1.18.3
version: 1.18.7

@coderabbitai coderabbitai Bot Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add chart-version validation or explain why tests are not applicable.

This dependency change has no accompanying repository-native test or validation evidence. Add a Helmfile render/version-resolution check, or document in the PR why testing is not applicable.

As per coding guidelines: “Code changes must include tests, or the Pull Request must explain why tests are not applicable.”

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl` at line 42, Add
validation for the chart version in the Helmfile configuration around the
version declaration, using a repository-native Helmfile render or
version-resolution check to verify the dependency resolves correctly. If such
validation is not applicable, document the justification in the PR instead.

Source: Coding guidelines

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find nearest AGENTS guidance files and inspect the relevant path scope.
printf '\n== AGENTS files ==\n'
find . -name AGENTS.md -print | sort

printf '\n== Relevant file snippets ==\n'
for f in \
  deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl \
  docs/user/manifest.md \
  docs/version-catalog/main.yaml
do
  if [ -f "$f" ]; then
    printf '\n--- %s ---\n' "$f"
    nl -ba "$f" | sed -n '1,260p' | rg -n 'helm-nvcf-sis|1\.18\.3|1\.18\.7|version:' -n -C 2 || true
  else
    printf '\n--- %s (missing) ---\n' "$f"
  fi
done

printf '\n== Search for SIS version sources ==\n'
rg -n 'helm-nvcf-sis|1\.18\.3|1\.18\.7' deploy docs -g '!**/node_modules/**' || true

Repository: NVIDIA/nvcf

Length of output: 3124

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== Root and docs guidance ==\n'
for f in AGENTS.md docs/AGENTS.md; do
  if [ -f "$f" ]; then
    printf '\n--- %s ---\n' "$f"
    sed -n '1,220p' "$f"
  fi
done

printf '\n== References to version-catalog and manifest generation ==\n'
rg -n 'version-catalog|manifest\.md|helm-nvcf-sis|user/manifest|docs/version-catalog' . \
  -g '!**/node_modules/**' -g '!**/dist/**' -g '!**/build/**' || true

printf '\n== Nearby context in docs/version-catalog/main.yaml ==\n'
sed -n '180,230p' docs/version-catalog/main.yaml

printf '\n== Nearby context in docs/user/manifest.md ==\n'
sed -n '78,100p' docs/user/manifest.md

Repository: NVIDIA/nvcf

Length of output: 36987

Sync the SIS version catalog and manifest. docs/version-catalog/main.yaml still pins helm-nvcf-sis to 1.18.3, so docs/user/manifest.md will stay out of sync with this Helmfile bump unless the catalog is updated and the manifest regenerated.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@deploy/stacks/self-managed/helmfile.d/02-core.yaml.gotmpl` at line 42, Update
the helm-nvcf-sis version in docs/version-catalog/main.yaml to match the 1.18.7
value in the Helmfile, then regenerate docs/user/manifest.md from the updated
catalog so both documentation artifacts are synchronized.

namespace: sis
inherit:
- template: service
Expand Down
Loading