fix(worker-llm-credentials): add subtree .bazelrc so the release image builds#432
Merged
Merged
Conversation
…e builds The release image is built from the isolated worker-llm-credentials subtree snapshot, which does not carry the umbrella .bazelrc. Without a subtree .bazelrc the release build fails with "Config value 'release' is not defined in any .rc file", and it would not build pure-Go for the distroless_go base. Every other releasable subtree ships its own .bazelrc; this one was missing. Add it, mirroring the sibling Go services (release/debug/ci profiles, pure Go, workspace stamping), minus the proto lines this service does not use. NO-REF
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a Bazel configuration for the LLM credentials worker, including global build and test settings, JVM and Go options, workspace stamping, and CI, debug, and release profiles. ChangesBazel configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Max-NV
requested review from
balajinvda and
kristinapathak
and removed request for
estroz
July 24, 2026 21:00
Contributor
|
🎉 This PR is included in version nvcf-worker-llm-credentials-v1.0.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
vrv3814
pushed a commit
to mesutoezdil/nvcf
that referenced
this pull request
Jul 25, 2026
) The release image is built from an isolated subtree snapshot, where the subtree's own MODULE.bazel is the workspace root, so bazelisk resolves .bazelversion from the subtree and never sees the umbrella's root pin. The four worker subtrees ship no .bazelversion, so their release builds run whatever bazelisk considers latest: the worker-llm-credentials v1.0.6 release build downloaded Bazel 9.2.0 while the repo pins 9.1.1 and the other 15 releasable subtrees pin their own version. That makes those builds non-reproducible and lets an upstream Bazel release break them with no change in this repo. Pin all four to 9.1.1, matching the root .bazelversion. Same root cause as the missing subtree .bazelrc fixed in NVIDIA#432 (the snapshot does not carry umbrella root files); that PR covers .bazelrc for worker-llm-credentials only, so .bazelversion is still needed for all four. Verified: worker-utils builds clean under USE_BAZEL_VERSION=9.1.1 (bazel build //..., 2115 actions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The worker-llm-credentials release image build (nvcf-internal) fails:
The release image is built from an isolated subtree snapshot cloned at the subtree tag, which does not carry the umbrella
.bazelrc(wherebuild:releaseand--@rules_go//go/config:purelive). Every other releasable subtree (nvca, worker-init, worker-utils, image-credential-helper, ...) ships its own.bazelrc; worker-llm-credentials was the only one missing it. The full-mono bazel CI passes because it uses the root.bazelrc, so this only surfaces at release build time. It was exposed by the firstfix:to cut a release for this subtree.What changed
Add
src/compute-plane-services/worker-llm-credentials/.bazelrc, mirroring the sibling Go services: bzlmod, pure Go (for thedistroless_gostatic base), workspace stamping (tools/workspace_status.sh), and therelease/debug/ciconfig profiles. Proto-toolchain lines are omitted since this service declares no protobuf module and has no proto targets.Customer Release Notes
Not customer visible.
Testing
Flags reference only native Bazel and
rules_go(declared in this subtree's MODULE.bazel), andtools/workspace_status.shexists. The isolated release-snapshot build cannot be reproduced locally (subtree dep resolution needs the CI proxy); the nvcf-internal release build validates it. A new release tag will pick up this file plus the already-merged worker-token change.References
None
Summary by CodeRabbit