Deprecate the hook config mode for cri-o#1314
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 17973486093Details
💛 - Coveralls |
tariq1890
approved these changes
Sep 23, 2025
Collaborator
ArangoGutierrez
left a comment
ArangoGutierrez
left a comment
There was a problem hiding this comment.
LGTM, I'll leave final approval to ELezar
elezar
reviewed
Sep 24, 2025
| Name = "crio" | ||
|
|
||
| defaultConfigMode = "hook" | ||
| defaultConfigMode = "config" |
Member
There was a problem hiding this comment.
My one question was whether we wanted to print a deprecation warning when hook is configured?
In this case we would also need to update the nvidia-ctk runtime configure command to issue a similar warning.
elezar
previously requested changes
Sep 24, 2025
elezar
force-pushed
the
switch-default-crio-config-mode
branch
from
5446a9e to
e1f0f36
Compare
Comment on lines
+139
to
+140
| Usage: "the path to the OCI runtime hook to create if --config-mode=oci-hook is specified. If no path is specified, the generated hook is output to STDOUT.\n" + | ||
| "\tNote: The use of OCI hooks is deprecated.", |
There was a problem hiding this comment.
[nitpick] String concatenation across multiple lines reduces readability. Consider using a multi-line string literal or keeping the original format for better maintainability.
Suggested change
| Usage: "the path to the OCI runtime hook to create if --config-mode=oci-hook is specified. If no path is specified, the generated hook is output to STDOUT.\n" + | |
| "\tNote: The use of OCI hooks is deprecated.", | |
| Usage: `the path to the OCI runtime hook to create if --config-mode=oci-hook is specified. If no path is specified, the generated hook is output to STDOUT. | |
| Note: The use of OCI hooks is deprecated.`, |
| } | ||
|
|
||
| func (opts *Options) Validate(logger logger.Interface, _ *cli.Command) error { | ||
| if opts.configMode == "hook" { |
There was a problem hiding this comment.
Use the defined constant configModeHook instead of the string literal "hook" for consistency with the newly introduced constants.
ArangoGutierrez
approved these changes
Sep 24, 2025
This chagne updates the default cri-o config mode from 'hook' to 'config' and issues a deprecation warning if hook is explicitly selected. Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com> Co-authored-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
switch-default-crio-config-mode
branch
from
e1f0f36 to
781bbe2
Compare
elezar
changed the title
elezar
approved these changes
Sep 24, 2025
Member
elezar
left a comment
elezar
left a comment
There was a problem hiding this comment.
Thanks @cdesiniotis.
I added the deprecation log messages as changes on-top.
Contributor
Author
|
Thanks @elezar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPU Operator is switching from 'hook' to 'config' by default in the next release. This change ensures the default behavior of the toolkit container and GPU Operator are aligned. We also add deprecation messages to cases where an OCI hook is explicitly requested.
See thread for additional context: NVIDIA/gpu-operator#1578 (comment)