docker.mk: Add Podman support and fix volume/artifact handling#1700
Open
flouthoc wants to merge 1 commit intoNVIDIA:mainfrom
Open
docker.mk: Add Podman support and fix volume/artifact handling#1700flouthoc wants to merge 1 commit intoNVIDIA:mainfrom
flouthoc wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
* Use `$(DOCKER)` for pull, build, run, images, and rmi so `DOCKER=podman` works * Default `DOCKER` to 'docker' in docker.mk when unset * Use localhost/ image prefix with Podman so run uses local image instead of pull * Add `:z` volume option with Podman for SELinux bind-mount write access * Create `ARTIFACTS_DIR` before container run to avoid missing directory errors Signed-off-by: flouthoc <flouthoc.git@gmail.com>
Author
|
@elezar Could you PTAL |
Author
|
@elezar Created a similar PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(DOCKER)for pull, build, run, images, and rmi soDOCKER=podmanworksDOCKERto 'docker' in docker.mk when unset:zvolume option with Podman for SELinux bind-mount write accessARTIFACTS_DIRbefore container run to avoid missing directory errors