Fix client-side bugs, dependency pins, and misc issues#76
Open
Gahrcoder wants to merge 7 commits intoNVIDIA:mainfrom
Open
Fix client-side bugs, dependency pins, and misc issues#76Gahrcoder wants to merge 7 commits intoNVIDIA:mainfrom
Gahrcoder wants to merge 7 commits intoNVIDIA:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Assorted fixes found while testing and reading through the codebase. One per commit.
Changes
Client-side
Queue.tsx — The eruda cleanup function in
useEffectwas never returned, soeruda.destroy()never runs on unmount.Conversation.tsx —
buildURLis a plain function but was callinguseMemoinside it, violating the Rules of Hooks. Replaced with a simple conditional.useSocket.ts —
onDisconnectwas firing the callback unconditionally, then again for the current socket. Stale socket close events now get ignored properly..eslinrc.json→.eslintrc.json— Filename was misspelled (missing 't'), so ESLint config was silently not loading.Server-side
loaders.py — Three
print()calls used%splaceholders but Python's print doesn't do printf formatting — these were printing tuples instead of formatted strings. Switched to f-strings.server.py —
hf_hub_download(repo, 'config.json')is analytics-only but crashes whenHF_HUB_OFFLINE=1is set (issue Disabling Huggingface access causes failure #54). Now skipped in offline mode.pyproject.toml —
torch < 2.5blocks Python 3.13 and CUDA 13.0/Blackwell support (issues PersonaPlex produces choppy/unusable audio on DGX Spark (GB10) #3, Current PyTorch dependencies don't work with CPython 3.13 #22).aiohttp < 3.11is also unnecessarily restrictive. Removed upper bounds for both.Testing
All changes are backwards-compatible. The React fixes resolve runtime errors that would occur on disconnect or component mount/unmount cycles.