Skip to content

Fix client-side bugs, dependency pins, and misc issues#76

Open
Gahrcoder wants to merge 7 commits intoNVIDIA:mainfrom
Gahrcoder:fix/misc-bugs
Open

Fix client-side bugs, dependency pins, and misc issues#76
Gahrcoder wants to merge 7 commits intoNVIDIA:mainfrom
Gahrcoder:fix/misc-bugs

Conversation

@Gahrcoder
Copy link
Copy Markdown

Summary

Assorted fixes found while testing and reading through the codebase. One per commit.

Changes

Client-side

  1. Queue.tsx — The eruda cleanup function in useEffect was never returned, so eruda.destroy() never runs on unmount.

  2. Conversation.tsxbuildURL is a plain function but was calling useMemo inside it, violating the Rules of Hooks. Replaced with a simple conditional.

  3. useSocket.tsonDisconnect was firing the callback unconditionally, then again for the current socket. Stale socket close events now get ignored properly.

  4. .eslinrc.json.eslintrc.json — Filename was misspelled (missing 't'), so ESLint config was silently not loading.

Server-side

  1. loaders.py — Three print() calls used %s placeholders but Python's print doesn't do printf formatting — these were printing tuples instead of formatted strings. Switched to f-strings.

  2. server.pyhf_hub_download(repo, 'config.json') is analytics-only but crashes when HF_HUB_OFFLINE=1 is set (issue Disabling Huggingface access causes failure #54). Now skipped in offline mode.

  3. pyproject.tomltorch < 2.5 blocks Python 3.13 and CUDA 13.0/Blackwell support (issues PersonaPlex produces choppy/unusable audio on DGX Spark (GB10) #3, Current PyTorch dependencies don't work with CPython 3.13 #22). aiohttp < 3.11 is also unnecessarily restrictive. Removed upper bounds for both.

Testing

All changes are backwards-compatible. The React fixes resolve runtime errors that would occur on disconnect or component mount/unmount cycles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant